[Mailer] When using Sendgrid with SMTP and no region, host is built incorrectly #59102
+41
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! Thanks for your PR. You are targeting branch "7.3" but it seems your PR description refers to branch "7.2". Cheers! Carsonbot |
d4138c5 to
8985658
Compare
|
Duplicate of #59099? |
nicolas-grekas
added a commit
that referenced
this pull request
Dec 7, 2024
This PR was merged into the 7.2 branch. Discussion ---------- [Mailer] add test covering null regions | Q | A | ------------- | --- | Branch? | 7.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | | License | MIT even if the fix in #59102 was a duplicate of #59099 having the test IMO is still a good idea Commits ------- 91f4a2c add test covering null regions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using Sendgrid with SMTP and no region, host is built incorrectly. This bug basically breaks sending emails via SMTP with Sengrid if there is no region configured.
Added failing test with current code:
After fix: