symfony · fabpot · Dec 18, 2024 · Dec 11, 2024
diff --git a/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php b/src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
@@ -2032,6 +2032,10 @@ private function registerJsonEncoderConfiguration(array $config, ContainerBuilde
         foreach ($config['paths'] as $namespace => $path) {
             $loader->registerClasses($encodableDefinition, $namespace, $path);
         }
+
+        if (\PHP_VERSION_ID >= 80400) {
+            $container->removeDefinition('.json_encoder.cache_warmer.lazy_ghost');
+        }
     }
 
     private function registerPropertyInfoConfiguration(ContainerBuilder $container, PhpFileLoader $loader): void

diff --git a/src/Symfony/Component/JsonEncoder/CHANGELOG.md b/src/Symfony/Component/JsonEncoder/CHANGELOG.md
@@ -5,3 +5,4 @@ CHANGELOG
 ---
 
  * Introduce the component as experimental
+ * Add native PHP lazy ghost support
diff --git a/src/Symfony/Component/JsonEncoder/Decode/LazyInstantiator.php b/src/Symfony/Component/JsonEncoder/Decode/LazyInstantiator.php
@@ -12,23 +12,23 @@
 namespace Symfony\Component\JsonEncoder\Decode;
 
 use Symfony\Component\Filesystem\Filesystem;
+use Symfony\Component\JsonEncoder\Exception\InvalidArgumentException;
 use Symfony\Component\JsonEncoder\Exception\RuntimeException;
 use Symfony\Component\VarExporter\ProxyHelper;
 
 /**
  * Instantiates a new $className lazy ghost {@see \Symfony\Component\VarExporter\LazyGhostTrait}.
  *
- * The $className class must not be final.
- *
- * A property must be a callable that returns the actual value when being called.
+ * Prior to PHP 8.4, the "$className" argument class must not be final.
+ * The $initializer must be a callable that sets the actual object values when being called.
  *
  * @author Mathias Arlaud <mathias.arlaud@gmail.com>
  *
  * @internal
  */
 final class LazyInstantiator
 {
-    private Filesystem $fs;
+    private ?Filesystem $fs = null;
 
     /**
      * @var array{reflection: array<class-string, \ReflectionClass<object>>, lazy_class_name: array<class-string, class-string>}
@@ -44,34 +44,37 @@
     private static array $lazyClassesLoaded = [];
 
     public function __construct(
-        private string $lazyGhostsDir,
+        private ?string $lazyGhostsDir = null,
     ) {
-        $this->fs = new Filesystem();
+        if (null === $this->lazyGhostsDir && \PHP_VERSION_ID < 80400) {
+            throw new InvalidArgumentException('The "$lazyGhostsDir" argument cannot be null when using PHP < 8.4.');
+        }
     }
 
     /**
      * @template T of object
      *
-     * @param class-string<T>                  $className
-     * @param array<string, callable(): mixed> $propertiesCallables
+     * @param class-string<T>   $className
+     * @param callable(T): void $initializer
      *
      * @return T
      */
-    public function instantiate(string $className, array $propertiesCallables): object
+    public function instantiate(string $className, callable $initializer): object
     {
         try {
             $classReflection = self::$cache['reflection'][$className] ??= new \ReflectionClass($className);
         } catch (\ReflectionException $e) {
             throw new RuntimeException($e->getMessage(), $e->getCode(), $e);
         }
 
-        $lazyClassName = self::$cache['lazy_class_name'][$className] ??= \sprintf('%sGhost', preg_replace('/\\\\/', '', $className));
+        // use native lazy ghosts if available
+        if (\PHP_VERSION_ID >= 80400) {
+            return $classReflection->newLazyGhost($initializer);
+        }
 
-        $initializer = function (object $object) use ($propertiesCallables) {
-            foreach ($propertiesCallables as $name => $propertyCallable) {
-                $object->{$name} = $propertyCallable();
-            }
-        };
+        $this->fs ??= new Filesystem();
+
+        $lazyClassName = self::$cache['lazy_class_name'][$className] ??= \sprintf('%sGhost', preg_replace('/\\\\/', '', $className));
 
         if (isset(self::$lazyClassesLoaded[$className]) && class_exists($lazyClassName)) {
             return $lazyClassName::createLazyGhost($initializer);

diff --git a/src/Symfony/Component/JsonEncoder/Decode/PhpAstBuilder.php b/src/Symfony/Component/JsonEncoder/Decode/PhpAstBuilder.php
@@ -53,8 +53,8 @@
 use Symfony\Component\TypeInfo\Type\BackedEnumType;
 use Symfony\Component\TypeInfo\Type\CollectionType;
 use Symfony\Component\TypeInfo\Type\ObjectType;
-use Symfony\Component\TypeInfo\TypeIdentifier;
 use Symfony\Component\TypeInfo\Type\WrappingTypeInterface;
+use Symfony\Component\TypeInfo\TypeIdentifier;
 
 /**
  * Builds a PHP syntax tree that decodes JSON.
@@ -445,21 +445,8 @@ private function buildObjectNodeStatements(ObjectNode $node, bool $decodeFromStr
                     );
 
                 $streamPropertiesValuesStmts[] = new MatchArm([$this->builder->val($encodedName)], new Assign(
-                    new ArrayDimFetch($this->builder->var('properties'), $this->builder->val($property['name'])),
-                    new Closure([
-                        'static' => true,
-                        'uses' => [
-                            new ClosureUse($this->builder->var('stream')),
-                            new ClosureUse($this->builder->var('v')),
-                            new ClosureUse($this->builder->var('options')),
-                            new ClosureUse($this->builder->var('denormalizers')),
-                            new ClosureUse($this->builder->var('instantiator')),
-                            new ClosureUse($this->builder->var('providers'), byRef: true),
-                        ],
-                        'stmts' => [
-                            new Return_($property['accessor'](new PhpExprDataAccessor($propertyValueStmt))->toPhpExpr()),
-                        ],
-                    ]),
+                    $this->builder->propertyFetch($this->builder->var('object'), $property['name']),
+                    $property['accessor'](new PhpExprDataAccessor($propertyValueStmt))->toPhpExpr(),
                 ));
             } else {
                 $propertyValueStmt = $this->nodeOnlyNeedsDecode($property['value'], $decodeFromStream)
@@ -494,17 +481,29 @@ private function buildObjectNodeStatements(ObjectNode $node, bool $decodeFromStr
 
         if ($decodeFromStream) {
             $instantiateStmts = [
-                new Expression(new Assign($this->builder->var('properties'), new Array_([], ['kind' => Array_::KIND_SHORT]))),
-                new Foreach_($this->builder->var('data'), $this->builder->var('v'), [
-                    'keyVar' => $this->builder->var('k'),
-                    'stmts' => [new Expression(new Match_(
-                        $this->builder->var('k'),
-                        [...$streamPropertiesValuesStmts, new MatchArm(null, $this->builder->val(null))],
-                    ))],
-                ]),
                 new Return_($this->builder->methodCall($this->builder->var('instantiator'), 'instantiate', [
                     new ClassConstFetch(new FullyQualified($node->getType()->getClassName()), 'class'),
-                    $this->builder->var('properties'),
+                    new Closure([
+                        'static' => true,
+                        'params' => [new Param($this->builder->var('object'))],
+                        'uses' => [
+                            new ClosureUse($this->builder->var('stream')),
+                            new ClosureUse($this->builder->var('data')),
+                            new ClosureUse($this->builder->var('options')),
+                            new ClosureUse($this->builder->var('denormalizers')),
+                            new ClosureUse($this->builder->var('instantiator')),
+                            new ClosureUse($this->builder->var('providers'), byRef: true),
+                        ],
+                        'stmts' => [
+                            new Foreach_($this->builder->var('data'), $this->builder->var('v'), [
+                                'keyVar' => $this->builder->var('k'),
+                                'stmts' => [new Expression(new Match_(
+                                    $this->builder->var('k'),
+                                    [...$streamPropertiesValuesStmts, new MatchArm(null, $this->builder->val(null))],
+                                ))],
+                            ]),
+                        ],
+                    ]),
                 ])),
             ];
         } else {

diff --git a/src/Symfony/Component/JsonEncoder/Encode/PhpAstBuilder.php b/src/Symfony/Component/JsonEncoder/Encode/PhpAstBuilder.php
@@ -45,8 +45,8 @@
 use Symfony\Component\JsonEncoder\Exception\RuntimeException;
 use Symfony\Component\JsonEncoder\Exception\UnexpectedValueException;
 use Symfony\Component\TypeInfo\Type\ObjectType;
-use Symfony\Component\TypeInfo\TypeIdentifier;
 use Symfony\Component\TypeInfo\Type\WrappingTypeInterface;
+use Symfony\Component\TypeInfo\TypeIdentifier;
 
 /**
  * Builds a PHP syntax tree that encodes data to JSON.

diff --git a/src/Symfony/Component/JsonEncoder/Mapping/GenericTypePropertyMetadataLoader.php b/src/Symfony/Component/JsonEncoder/Mapping/GenericTypePropertyMetadataLoader.php
@@ -18,8 +18,8 @@
 use Symfony\Component\TypeInfo\Type\IntersectionType;
 use Symfony\Component\TypeInfo\Type\ObjectType;
 use Symfony\Component\TypeInfo\Type\UnionType;
-use Symfony\Component\TypeInfo\TypeContext\TypeContextFactory;
 use Symfony\Component\TypeInfo\Type\WrappingTypeInterface;
+use Symfony\Component\TypeInfo\TypeContext\TypeContextFactory;
 
 /**
  * Enhances properties encoding/decoding metadata based on properties' generic type.

diff --git a/src/Symfony/Component/JsonEncoder/Tests/Decode/LazyInstantiatorTest.php b/src/Symfony/Component/JsonEncoder/Tests/Decode/LazyInstantiatorTest.php
@@ -13,6 +13,7 @@
 
 use PHPUnit\Framework\TestCase;
 use Symfony\Component\JsonEncoder\Decode\LazyInstantiator;
+use Symfony\Component\JsonEncoder\Exception\InvalidArgumentException;
 use Symfony\Component\JsonEncoder\Tests\Fixtures\Model\ClassicDummy;
 use Symfony\Component\JsonEncoder\Tests\Fixtures\Model\DummyWithNormalizerAttributes;
 
@@ -32,17 +33,46 @@ protected function setUp(): void
         }
     }
 
-    public function testCreateLazyGhost()
+    /**
+     * @requires PHP < 8.4
+     */
+    public function testCreateLazyGhostUsingVarExporter()
     {
-        $ghost = (new LazyInstantiator($this->lazyGhostsDir))->instantiate(ClassicDummy::class, []);
+        $ghost = (new LazyInstantiator($this->lazyGhostsDir))->instantiate(ClassicDummy::class, function (ClassicDummy $object): void {
+            $object->id = 123;
+        });
 
-        $this->assertArrayHasKey(\sprintf("\0%sGhost\0lazyObjectState", preg_replace('/\\\\/', '', ClassicDummy::class)), (array) $ghost);
+        $this->assertSame(123, $ghost->id);
     }
 
+    /**
+     * @requires PHP < 8.4
+     */
     public function testCreateCacheFile()
     {
-        (new LazyInstantiator($this->lazyGhostsDir))->instantiate(DummyWithNormalizerAttributes::class, []);
+        (new LazyInstantiator($this->lazyGhostsDir))->instantiate(DummyWithNormalizerAttributes::class, function (ClassicDummy $object): void {});
 
         $this->assertCount(1, glob($this->lazyGhostsDir.'/*'));
     }
+
+    /**
+     * @requires PHP < 8.4
+     */
+    public function testThrowIfLazyGhostDirNotDefined()
+    {
+        $this->expectException(InvalidArgumentException::class);
+        new LazyInstantiator();
+    }
+
+    /**
+     * @requires PHP 8.4
+     */
+    public function testCreateLazyGhostUsingPhp()
+    {
+        $ghost = (new LazyInstantiator())->instantiate(ClassicDummy::class, function (ClassicDummy $object): void {
+            $object->id = 123;
+        });
+
+        $this->assertSame(123, $ghost->id);
+    }
 }
diff --git a/src/Symfony/Component/JsonEncoder/Tests/Fixtures/decoder/nullable_object.stream.php b/src/Symfony/Component/JsonEncoder/Tests/Fixtures/decoder/nullable_object.stream.php
diff --git a/src/Symfony/Component/JsonEncoder/Tests/Fixtures/decoder/nullable_object_dict.stream.php b/src/Symfony/Component/JsonEncoder/Tests/Fixtures/decoder/nullable_object_dict.stream.php
diff --git a/src/Symfony/Component/JsonEncoder/Tests/Fixtures/decoder/nullable_object_list.stream.php b/src/Symfony/Component/JsonEncoder/Tests/Fixtures/decoder/nullable_object_list.stream.php
diff --git a/src/Symfony/Component/JsonEncoder/Tests/Fixtures/decoder/object.stream.php b/src/Symfony/Component/JsonEncoder/Tests/Fixtures/decoder/object.stream.php
Original file line number	Diff line number	Diff line change
Expand Up		@@ -5,3 +5,4 @@ CHANGELOG
		---

		* Introduce the component as experimental
		* Add native PHP lazy ghost support