Skip to content

[PropertyInfo] Fix add missing composer conflict #59245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 6, 2025

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Dec 18, 2024

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

Add missing composer conflicts in PropertyInfo component

@mtarld mtarld force-pushed the fix/property-info-conflict branch from 10b15fe to 099e8c9 Compare January 6, 2025 09:21
@fabpot
Copy link
Member

fabpot commented Jan 6, 2025

Re-reading this PR, it says "Add missing", but it also removes 2 conflicts, is it on purpose? If yes, why?

@mtarld mtarld force-pushed the fix/property-info-conflict branch from 099e8c9 to c962324 Compare January 6, 2025 09:55
@mtarld
Copy link
Contributor Author

mtarld commented Jan 6, 2025

Actually, it's a half/half:

  • symfony/dependency-injection was duplicated
  • phpdocumentor/type-resolver is indeed a mistake of mine

I'm going to fix it!

@fabpot
Copy link
Member

fabpot commented Jan 6, 2025

Thank you @mtarld.

@fabpot fabpot merged commit 8529b41 into symfony:6.4 Jan 6, 2025
11 checks passed
@mtarld mtarld deleted the fix/property-info-conflict branch January 6, 2025 10:14
This was referenced Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants