Skip to content

[PropertyInfo] Remove @internal from PropertyReadInfo and PropertyWriteInfo #59304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

Guarrakesh
Copy link

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues Fix #58988
License MIT

@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 7.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot

This comment was marked as outdated.

@Guarrakesh Guarrakesh changed the base branch from 7.3 to 6.4 December 26, 2024 19:04
@carsonbot carsonbot changed the title Fix/property info remove internal directives [PropertyInfo] Fix/property info remove internal directives Dec 30, 2024
@OskarStark OskarStark changed the title [PropertyInfo] Fix/property info remove internal directives [PropertyInfo] remove @internal from Dec 30, 2024
@OskarStark OskarStark changed the title [PropertyInfo] remove @internal from [PropertyInfo] remove @internal from PropertyReadInfo and PropertyWriteInfo Dec 30, 2024
@OskarStark OskarStark modified the milestones: 7.3, 6.4 Dec 30, 2024
@OskarStark
Copy link
Contributor

OskarStark commented Dec 30, 2024

friendly ping @mtarld

@OskarStark OskarStark changed the title [PropertyInfo] remove @internal from PropertyReadInfo and PropertyWriteInfo [PropertyInfo] Remove @internal from PropertyReadInfo and PropertyWriteInfo Dec 30, 2024
@chalasr
Copy link
Member

chalasr commented Dec 31, 2024

Thank you @Guarrakesh.

@chalasr chalasr merged commit 52d2ab9 into symfony:6.4 Dec 31, 2024
11 checks passed
This was referenced Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants