[Routing] Fix configuring a single route's hosts #59446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Jan 9, 2025
|
Thank you @MatTheCat. |
This was referenced Jan 29, 2025
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All loaders were affected by this issue: when you configure a route it is immediately added to the main collection and in the one returned by the
LocalizedRouteTrait. Problem is: only the latter is updated when configuring hosts, which means they will be ignored.This PR merges these two collections, with a twist: after its hosts are configured, a route may have to be removed from the main collection (like
staticbecomingstatic.nlandstatic.enin the tests).