Skip to content

[PropertyInfo] Deprecate Type #59902

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 22, 2025
Merged

[PropertyInfo] Deprecate Type #59902

merged 2 commits into from
Mar 22, 2025

Conversation

mtarld
Copy link
Contributor

@mtarld mtarld commented Mar 3, 2025

Q A
Branch? 7.3
Bug fix? no
New feature? no
Deprecations? yes
Issues
License MIT

A new attempt to #53160, now that symfony/type-info is not experimental anymore.

Deprecates:

  • Type class in favor of the Type class of symfony/type-info
  • PropertyTypeExtractorInterface::getTypes() in favor of the PropertyTypeExtractorInterface::getType() method
  • ConstructorArgumentTypeExtractorInterface::getTypesFromConstructor() in favor of the ConstructorArgumentTypeExtractorInterface::getTypeFromConstructor() method

The work for upgrading dependent packages has begun already:

@mtarld mtarld requested a review from dunglas as a code owner March 3, 2025 11:12
@carsonbot carsonbot added this to the 7.3 milestone Mar 3, 2025
@alexandre-daubois
Copy link
Member

I think your tests should expect deprecations as well by using the ExpectDeprecationTrait, additionally to the legacy group. It also helps to show explicitly why the legacy group is used and speed up cleaning on next major 🙂

@mtarld mtarld force-pushed the fix/deprecate-property-info-type branch from efaf7fe to a9d3291 Compare March 3, 2025 13:51
@mtarld
Copy link
Contributor Author

mtarld commented Mar 3, 2025

Indeed, that'll be great! Updated.

chalasr
chalasr reviewed Mar 3, 2025
View reviewed changes
chalasr
chalasr reviewed Mar 3, 2025
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 (2 minor comments)

@mtarld mtarld force-pushed the fix/deprecate-property-info-type branch from a9d3291 to 3decf95 Compare March 5, 2025 13:28
nicolas-grekas
nicolas-grekas approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rebase needed

@mtarld mtarld force-pushed the fix/deprecate-property-info-type branch from 3decf95 to f819aed Compare March 22, 2025 13:45
OskarStark
OskarStark reviewed Mar 22, 2025
View reviewed changes
@chalasr
Copy link
Member

chalasr commented Mar 22, 2025

Thank you @mtarld.

@chalasr chalasr merged commit 2468bae into symfony:7.3 Mar 22, 2025
11 checks passed
@chalasr chalasr mentioned this pull request Mar 22, 2025
Open
@mtarld mtarld deleted the fix/deprecate-property-info-type branch March 22, 2025 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark OskarStark left review comments

@chalasr chalasr chalasr approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Deprecation PropertyInfo Status: Reviewed
Projects
None yet
Milestone
7.3
Development

Successfully merging this pull request may close these issues.
6 participants
@mtarld @alexandre-daubois @chalasr @nicolas-grekas @OskarStark @carsonbot