Add PHP config support for routing #60232
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Apr 17, 2025
|
To avoid maintaining route definition twice, should we make our XML files import the PHP file ? |
|
Can we trigger a runtime deprecation? :) (if xml imports php, maybe we can trace that) |
c8b8b19 to
88d40c7
Compare
88d40c7 to
3225a15
Compare
3225a15 to
2a5aa45
Compare
Done |
Done (hackish, tell me if there is something "better" as I want the deprecation to be local to the code) |
|
Recipes updated in symfony/recipes#1407 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first to stop using XML for the routing configuration provided by core bundles. We did the same for all other configuration files a while ago, so this is really the last step.