Skip to content

[VarExporter] dump default value for property hooks if present #60288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 27, 2025

Q A
Branch? 6.4
Bug fix? yes
New feature? no
Deprecations? no
Issues
License MIT

The test added in #60258 reveals that we have another bug in our lazy ghost generation logic which leads to an error at runtime when a hook tries to read the property's default value.

@carsonbot carsonbot added this to the 6.4 milestone Apr 27, 2025
@carsonbot carsonbot changed the title [VarExporter] dump default value for property hooks if present [VarExporter] dump default value for property hooks if present Apr 27, 2025
@fabpot
Copy link
Member

fabpot commented May 2, 2025

Thank you @xabbuh.

@fabpot fabpot merged commit b5b27a8 into symfony:6.4 May 2, 2025
11 checks passed
@xabbuh xabbuh deleted the pr-60258 branch May 2, 2025 08:38
This was referenced May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants