[Messenger] Fix integration with newer versions of Pheanstalk #60308
+134
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HypeMC
commented
May 1, 2025
| @@ -520,4 +606,5 @@ public function testSendWithRoundedDelay() | |||
|
|
|||
| interface PheanstalkInterface extends PheanstalkPublisherInterface, PheanstalkSubscriberInterface, PheanstalkManagerInterface | |||
| { | |||
| public function disconnect(): void; | |||
There was a problem hiding this comment.
Version 5 doesn't include this method in any of its interfaces (probably to avoid a BC break), but the implementation does. Version 7 adds it to the interface.
fabpot
approved these changes
May 8, 2025
|
Thank you @HypeMC. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #60040.
When I updated the Pheanstalk library, I missed the fact that version 4 internally tracked the used/watched tube. This was removed in newer versions, so now every call to
useTube()orwatch()sends a command to Beanstalkd, leading to unnecessary bandwidth consumption.This PR adds simple tracking logic to avoid redundant calls to those functions.