WIP [Routing] add scheme and method route definition option #6049
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -98,6 +122,8 @@ public function unserialize($data) | |||
| $this->defaults = $data['defaults']; | |||
| $this->requirements = $data['requirements']; | |||
| $this->options = $data['options']; | |||
| $this->schemes = $data['schemes']; | |||
| $this->methods = $data['options']; | |||
There was a problem hiding this comment.
$data['options'] => $data['methods'] ?
it uses an attribute list instead of multiple scheme/method elements that I also experimented with
|
@fabpot: Instead of the current xml attributes <route id="article_edit" pattern="/article/{id}}">
<method>POST</method>
<method>PUT</method>
<scheme>https</scheme>
</route>But I think it's not that good as you need to specify multiple elements without key. <import resource="file.xml">
<method></method>
</route>So I think a whitespace separated attribute list is the better choice. There is also an XSD type for such things (see implementation |
|
@Tobion I'd go with comma separated list of methods and schemes in xml and strip the spaces. BTW I'm pretty sure that schemes should be schemas |
|
Well, I used a whitespace separated list because it seems that this is the standard ways of using lists in XML. Because the xsd:list explicitly expects a whitespace separated list. |
|
I suggested the comma separated because, I can see myself automatically writing them like that as this is how I usually write lists. |
|
I could implement it so that both |
Merged
fabpot
added a commit
that referenced
this pull request
Jan 15, 2013
This PR was merged into the master branch. Commits ------- 9fc7def added the UPGRADE file for Symfony 3.0 e84cad2 [Routing] updated CHANGELOG 65eca8a [Routing] added new schemes and methods options to the annotation loader 5082994 [Routing] renamed pattern to path b357caf [Routing] renamed hostname pattern to just hostname e803f46 made schemes and methods available in XmlFileLoader d374e70 made schemes and methods available in YamlFileLoader 2834e7e added scheme and method setter in RouteCollection 10183de make scheme and method requirements first-class citizen in Route Discussion ---------- Routing options | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #5989, #5990, #6049 | License | MIT In #5989, it has unanimously been decided to renamed `hostname_pattern` to `hostname` and `pattern` to `path`. That makes a lot of sense and I would like to do the renaming now as `hostname_pattern` is new in Symfony 2.2, so I'd like to avoid breaking BC just after the release. As we are modifying the route options, I've also included changes introduced by @Tobion in #6049 which were discussed in #5990. As everything is BC, I think it's wise to include that in 2.2. What do you think? --------------------------------------------------------------------------- by Tobion at 2013-01-14T18:25:53Z I agree it should be done in 2.2. Thanks for working on it. --------------------------------------------------------------------------- by vicb at 2013-01-14T23:11:12Z @fabpot "Everything is BC" until it breaks BC in 3.0, that's why I'd like to see [deprecations in PR summary](symfony/symfony-docs#2116) what do you think ? --------------------------------------------------------------------------- by vicb at 2013-01-14T23:16:40Z it would also be great to update the CHANGELOG with deprecations (it could also help people answering your question) --------------------------------------------------------------------------- by fabpot at 2013-01-15T07:07:03Z @vicb: I've just updated the CHANGELOG and created the UPGRADE file for 3.0. --------------------------------------------------------------------------- by vicb at 2013-01-15T07:15:32Z @fabpot thanks.
ondrejmirtes
pushed a commit
to ondrejmirtes/symfony
that referenced
this pull request
Nov 25, 2013
This PR was merged into the 2.2 branch. Commits ------- 54c333d [Routing] unify and fix the loader tests 41ad9d8 [Routing] make xml loader more tolerant Discussion ---------- [Routing] make xml loader more tolerant schemes and methods may also be delimited by whitespace, comma or pipe. Fixes symfony#6049 (comment) this eases migration as now `methods="GET|POST"` also works the second commit unifies the tests and fixes some strange assertions that were useless | Q | A | ------------- | --- | Bug fix? | [yes] | New feature? | [yes but not really] | BC breaks? | [no] | Deprecations? | [no] | Tests pass? | [yes] | License | MIT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #5990
BC break: no
Deprecations: specifying
_schemeand_methodin the requirements section has been deprecated. you should use the dedicatedschemesandmethodsconfig options instead. for BC both possibilities are synchronized.Before
After
Before
After
WIP