[Messenger] Messenger: add --duration option to messenger:stop-workers command
#60517
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Please add a line in the changelog. Please use 7.4 there, as 7.3 is already in feature freeze 🥶 It looks that your committer email is not associated with your GitHub account, you might want to check this. |
|
ref #54037 we currently do something like but pausing the worker can be useful too 👍 (for example we'd like to indefinitely pause when upgrading the queue server, to resume/restart workers after) that said i would name this option |
5be2d14 to
3c603a7
Compare
3c603a7 to
779fcb2
Compare
| 7.4 | ||
| --- | ||
|
|
||
| * Add `--duration` option to `messenger:stop-workers` command to keep workers in paused state. |
There was a problem hiding this comment.
| * Add `--duration` option to `messenger:stop-workers` command to keep workers in paused state. | |
| * Add `--duration` option to `messenger:stop-workers` command to keep workers in paused state |
--duration option to messenger:stop-workers command
Hi!
My proposal is to add a
--durationoption to themessenger:stop-workerscommand, which would allow to "pause" the workers for the amount of time specified in this option.For example, if we pass
--duration=10, then for the next 10 seconds, runningmessenger:consumewill return a message indicating how many seconds are left until the "pause" ends.I think this option would be helpful during deployments (we're using it this way in my company).