[Notifier] Fix Clicksend transport #60524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you please add a test case or adjust an existing if already present? Thanks |
|
AmpHttpClientTest error seem unrelated to my change |
fabpot
approved these changes
May 23, 2025
|
Thank you @BafS. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
It seems to be an old issue (see #52486) but the format sent to Clicksend is not correct. When using the library we have this error:
[Symfony\Component\Notifier\Exception\TransportException] Unable to send the SMS - "{"http_code":400,"response_code":"BAD_REQUEST","response_msg":"The messages array is empty.","data":null}". The correct structure should have a "messages" key (see documentation: https://developers-dev.clicksend.net/docs/messaging/sms/other/send-sms).