From 1d839809e1ab70fa248200a97dd3a0aa67e44f2f Mon Sep 17 00:00:00 2001 From: Nicolas Grekas Date: Fri, 15 Aug 2025 14:18:53 +0200 Subject: [PATCH] Remove direct access to internal properties cross-components --- .../Bridge/Doctrine/Tests/Validator/DoctrineLoaderTest.php | 2 +- .../Tests/Extension/Validator/ValidatorExtensionTest.php | 4 ++-- .../Core/Tests/Validator/Constraints/UserPasswordTest.php | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/src/Symfony/Bridge/Doctrine/Tests/Validator/DoctrineLoaderTest.php b/src/Symfony/Bridge/Doctrine/Tests/Validator/DoctrineLoaderTest.php index ef304114be0c4..a5ca51669abb0 100644 --- a/src/Symfony/Bridge/Doctrine/Tests/Validator/DoctrineLoaderTest.php +++ b/src/Symfony/Bridge/Doctrine/Tests/Validator/DoctrineLoaderTest.php @@ -214,7 +214,7 @@ public function testClassNoAutoMapping() /** @var PropertyMetadata[] $autoMappingExplicitlyEnabledMetadata */ $autoMappingExplicitlyEnabledMetadata = $classMetadata->getPropertyMetadata('autoMappingExplicitlyEnabled'); - $this->assertCount(1, $autoMappingExplicitlyEnabledMetadata[0]->constraints); + $this->assertCount(1, $autoMappingExplicitlyEnabledMetadata[0]->getConstraints()); $this->assertSame(AutoMappingStrategy::ENABLED, $autoMappingExplicitlyEnabledMetadata[0]->getAutoMappingStrategy()); } } diff --git a/src/Symfony/Component/Form/Tests/Extension/Validator/ValidatorExtensionTest.php b/src/Symfony/Component/Form/Tests/Extension/Validator/ValidatorExtensionTest.php index c92bbe6651904..b721a11530b11 100644 --- a/src/Symfony/Component/Form/Tests/Extension/Validator/ValidatorExtensionTest.php +++ b/src/Symfony/Component/Form/Tests/Extension/Validator/ValidatorExtensionTest.php @@ -42,8 +42,8 @@ public function test2Dot5ValidationApi() $this->assertCount(1, $metadata->getConstraints()); $this->assertInstanceOf(FormConstraint::class, $metadata->getConstraints()[0]); - $this->assertSame(CascadingStrategy::NONE, $metadata->cascadingStrategy); - $this->assertSame(TraversalStrategy::NONE, $metadata->traversalStrategy); + $this->assertSame(CascadingStrategy::NONE, $metadata->getCascadingStrategy()); + $this->assertSame(TraversalStrategy::NONE, $metadata->getTraversalStrategy()); $this->assertCount(0, $metadata->getPropertyMetadata('children')); } } diff --git a/src/Symfony/Component/Security/Core/Tests/Validator/Constraints/UserPasswordTest.php b/src/Symfony/Component/Security/Core/Tests/Validator/Constraints/UserPasswordTest.php index ed4ca4427798d..3c42c9bc74015 100644 --- a/src/Symfony/Component/Security/Core/Tests/Validator/Constraints/UserPasswordTest.php +++ b/src/Symfony/Component/Security/Core/Tests/Validator/Constraints/UserPasswordTest.php @@ -42,7 +42,7 @@ public static function provideServiceValidatedConstraints(): iterable $metadata = new ClassMetadata(UserPasswordDummy::class); self::assertTrue((new AttributeLoader())->loadClassMetadata($metadata)); - yield 'attribute' => [$metadata->properties['b']->constraints[0]]; + yield 'attribute' => [$metadata->getPropertyMetadata('b')[0]->getConstraints()[0]]; } public function testAttributes() @@ -50,12 +50,12 @@ public function testAttributes() $metadata = new ClassMetadata(UserPasswordDummy::class); self::assertTrue((new AttributeLoader())->loadClassMetadata($metadata)); - [$bConstraint] = $metadata->properties['b']->getConstraints(); + [$bConstraint] = $metadata->getPropertyMetadata('b')[0]->getConstraints(); self::assertSame('myMessage', $bConstraint->message); self::assertSame(['Default', 'UserPasswordDummy'], $bConstraint->groups); self::assertNull($bConstraint->payload); - [$cConstraint] = $metadata->properties['c']->getConstraints(); + [$cConstraint] = $metadata->getPropertyMetadata('c')[0]->getConstraints(); self::assertSame(['my_group'], $cConstraint->groups); self::assertSame('some attached data', $cConstraint->payload); }