[2.4][HttpKernel] Fix profiler event-listener usage outside request stack context #9628
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
fabpot
added a commit
that referenced
this pull request
Nov 27, 2013
… request stack context (romainneutron) This PR was merged into the 2.4 branch. Discussion ---------- [2.4][HttpKernel] Fix profiler event-listener usage outside request stack context | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | License | MIT The bug has been reported at silexphp/Silex-WebProfiler#27 todo : - [x] add unit test Commits ------- 55a76e7 [HttpKernel] Fix profiler event-listener usage outside request stack context
nicolas-grekas
added a commit
that referenced
this pull request
Aug 7, 2017
This PR was merged into the 3.3 branch. Discussion ---------- [HttpKernel] Remove isset call used for legacy | Q | A | ------------- | --- | Branch? | 3.3 <!-- see comment below --> | Bug fix? | no | New feature? | no <!-- don't forget updating src/**/CHANGELOG.md files --> | BC breaks? | no | Deprecations? | no <!-- don't forget updating UPGRADE-*.md files --> | Tests pass? | yes | Fixed tickets | N/A <!-- #-prefixed issue number(s), if any --> | License | MIT | Doc PR | N/A Added in #9628 in which the request stack dependency was nullable. Forgotten to be removed in #14634. Commits ------- e0a6010 [HttpKernel] Remove isset call used for legacy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug has been reported at silexphp/Silex-WebProfiler#27
todo :