Skip to content

[Debug] ExceptionHandlerInterface to allow third party exception handlers to handle fatal errors caught by ErrorHandler #9629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

FineWolf
Copy link
Contributor

Q A
Bug fix? yes (other project)
New feature? yes
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets
Related tickets schmittjoh/JMSDebuggingBundle#68
License MIT
Doc PR

The current ErrorHandler is extremely strict on how it selects whether to run an ExceptionHandler when an E_FATAL occurs.

This modification allows any class that implements ExceptionHandlerInterface to handle a FatalErrorException created by the ErrorHandler.

@FineWolf
Copy link
Contributor Author

Ping @fabpot, since you are the author of the original file

* @param \Exception $exception An \Exception instance
*/
public function handle(\Exception $exception);
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

run php-cs-fixer

@fabpot
Copy link
Member

fabpot commented Feb 28, 2014

This is a new feature, so this must be done on the master branch. As the code has evolved quite a bit since 2.3, can you submit a new PR on master and close this one? Thanks.

@FineWolf FineWolf closed this Feb 28, 2014
@FineWolf FineWolf deleted the exception-handler-interface branch February 28, 2014 14:32
@FineWolf
Copy link
Contributor Author

Closed, see #10353 for version on master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants