Skip to content

[Routing][FrameworkBundle] Deprecated the apache dumper #9980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

[Routing][FrameworkBundle] Deprecated the apache dumper #9980

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbcab14
[Routing][FrameworkBundle] Deprecated the ApacheMatcherDumper, Apache…
jakzal Jan 8, 2014
d524eec
Documented removal of the apache matcher dumper in 3.0.
jakzal Jan 13, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions UPGRADE-3.0.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,6 +271,8 @@ UPGRADE FROM 2.x to 3.0
<?php echo $view['form']->end($form) ?>
```

* The `RouterApacheDumperCommand` was removed.

### HttpKernel

* The `Symfony\Component\HttpKernel\Log\LoggerInterface` has been removed in
Expand Down Expand Up @@ -381,6 +383,10 @@ UPGRADE FROM 2.x to 3.0
$route->setSchemes('https');
```

* The `ApacheMatcherDumper` and `ApacheUrlMatcher` were removed since
the performance gains were minimal and it's hard to replicate the behaviour
of PHP implementation.

### Security

* The `Resources/` directory was moved to `Core/Resources/`
Expand Down
3 changes: 2 additions & 1 deletion src/Symfony/Bundle/FrameworkBundle/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ CHANGELOG
2.5.0
-----

* Added `yaml:lint` command
* Added `yaml:lint` command
* Deprecated the `RouterApacheDumperCommand` which will be removed in Symfony 3.0.

2.4.0
-----
Expand Down
4 changes: 4 additions & 0 deletions src/Symfony/Bundle/FrameworkBundle/Command/RouterApacheDumperCommand.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,10 @@
/**
* RouterApacheDumperCommand.
*
* @deprecated Deprecated since version 2.5, to be removed in 3.0.
* The performance gains are minimal and it's very hard to replicate
* the behavior of PHP implementation.
*
* @author Fabien Potencier <fabien@symfony.com>
*/
class RouterApacheDumperCommand extends ContainerAwareCommand
Expand Down
7 changes: 7 additions & 0 deletions src/Symfony/Component/Routing/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,13 @@
CHANGELOG
=========

2.5.0
-----

* [DEPRECATION] The `ApacheMatcherDumper` and `ApacheUrlMatcher` were deprecated and
will be removed in Symfony 3.0, since the performance gains were minimal and
it's hard to replicate the behaviour of PHP implementation.

2.3.0
-----

Expand Down
4 changes: 4 additions & 0 deletions src/Symfony/Component/Routing/Matcher/ApacheUrlMatcher.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
/**
* ApacheUrlMatcher matches URL based on Apache mod_rewrite matching (see ApacheMatcherDumper).
*
* @deprecated Deprecated since version 2.5, to be removed in 3.0.
* The performance gains are minimal and it's very hard to replicate
* the behavior of PHP implementation.
*
* @author Fabien Potencier <fabien@symfony.com>
* @author Arnaud Le Blanc <arnaud.lb@gmail.com>
*/
Expand Down
4 changes: 4 additions & 0 deletions src/Symfony/Component/Routing/Matcher/Dumper/ApacheMatcherDumper.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,10 @@
/**
* Dumps a set of Apache mod_rewrite rules.
*
* @deprecated Deprecated since version 2.5, to be removed in 3.0.
* The performance gains are minimal and it's very hard to replicate
* the behavior of PHP implementation.
*
* @author Fabien Potencier <fabien@symfony.com>
* @author Kris Wallsmith <kris@symfony.com>
*/
Expand Down