Skip to content

Commit 142eb68

Browse files
javiereguiluzjaviereguiluz
committed
minor #13504 [Contributing] Fix trigger_error() position in deprecated class (fsoedjede)
This PR was merged into the 3.4 branch. Discussion ---------- [Contributing] Fix `trigger_error()` position in deprecated class The code was added in commit: a2c04e7 The change introducing the issue was added in the PR: #12075 <!-- If your pull request fixes a BUG, use the oldest maintained branch that contains the bug (see https://symfony.com/roadmap for the list of maintained branches). If your pull request documents a NEW FEATURE, use the same Symfony branch where the feature was introduced (and `master` for features of unreleased versions). --> Commits ------- 0dc5efc [Contributing] Fix `trigger_error()` position in deprecated class
2 parents fa8cb2b + 0dc5efc commit 142eb68

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎contributing/code/conventions.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ the Web Debug Toolbar or by the PHPUnit bridge).
129129
.. _`@-silencing operator`: https://php.net/manual/en/language.operators.errorcontrol.php
130130

131131
When deprecating a whole class the ``trigger_error()`` call should be placed
132-
between the namespace and the use declarations, like in this example from
132+
after the use declarations, like in this example from
133133
`ServiceRouterLoader`_::
134134

135135
namespace Symfony\Component\Routing\Loader\DependencyInjection;

0 commit comments

Comments
 (0)