minor #10129 Remove useless $request (ismail1432)

javiereguiluz · javiereguiluz · commit 278659eccbe1 · 2018-07-30T15:34:13.000+02:00
This PR was submitted for the 4.1 branch but it was merged into the 2.8 branch instead (closes #10129). Discussion ---------- Remove useless $request AFAICS the Request class doesn't needs to be injected in the login action, in the example we don't use it.  Commits ------- f22988f Remove useless $request
diff --git a/security/form_login_setup.rst b/security/form_login_setup.rst
@@ -91,15 +91,14 @@ configuration (``login``):
         // src/AppBundle/Controller/SecurityController.php
 
         // ...
-        use Symfony\Component\HttpFoundation\Request;
         use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 
         class SecurityController extends Controller
         {
             /**
              * @Route("/login", name="login")
              */
-            public function loginAction(Request $request)
+            public function loginAction()
             {
             }
         }
@@ -142,7 +141,7 @@ Great! Next, add the logic to ``loginAction()`` that displays the login form::
 
     // src/AppBundle/Controller/SecurityController.php
 
-    public function loginAction(Request $request)
+    public function loginAction()
     {
         $authenticationUtils = $this->get('security.authentication_utils');
 

Original file line number	Diff line number	Diff line change
@@ -91,15 +91,14 @@ configuration (``login``):
`91`	`91`	`// src/AppBundle/Controller/SecurityController.php`
`92`	`92`
`93`	`93`	`// ...`
`94`		`- use Symfony\Component\HttpFoundation\Request;`
`95`	`94`	`use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;`
`96`	`95`
`97`	`96`	`class SecurityController extends Controller`
`98`	`97`	`{`
`99`	`98`	`/**`
`100`	`99`	`* @Route("/login", name="login")`
`101`	`100`	`*/`
`102`		`- public function loginAction(Request $request)`
	`101`	`+ public function loginAction()`
`103`	`102`	`{`
`104`	`103`	`}`
`105`	`104`	`}`
@@ -142,7 +141,7 @@ Great! Next, add the logic to ``loginAction()`` that displays the login form::
`142`	`141`
`143`	`142`	`// src/AppBundle/Controller/SecurityController.php`
`144`	`143`
`145`		`- public function loginAction(Request $request)`
	`144`	`+ public function loginAction()`
`146`	`145`	`{`
`147`	`146`	`$authenticationUtils = $this->get('security.authentication_utils');`
`148`	`147`