minor #5476 [Cookbook][Security] some additional tweaks for the voter cookbook (xabbuh)

weaverryan · weaverryan · commit 2874a677a51e · 2015-07-25T13:22:39.000-04:00
This PR was merged into the 2.6 branch. Discussion ---------- [Cookbook][Security] some additional tweaks for the voter cookbook | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.6+ | Fixed tickets | This applies the comments left by @wouterj in e46f02e. Commits ------- 10e022d some additional tweaks for the voter cookbook
diff --git a/cookbook/security/voters.rst b/cookbook/security/voters.rst
@@ -105,8 +105,8 @@ edit a particular object. Here's an example implementation:
 
                     break;
                 case self::EDIT:
-                    // we assume that our data object has a method getOwner() to
-                    // get the current owner user entity for this data object
+                    // this assumes that the data object has a getOwner() method
+                    // to get the entity of the user who owns this data object
                     if ($user->getId() === $post->getOwner()->getId()) {
                         return true;
                     }
@@ -218,9 +218,7 @@ from the authorization checker is called.
 
             $authChecker = $this->get('security.authorization_checker');
 
-            if (false === $authChecker->isGranted('view', $post)) {
-                throw $this->createAccessDeniedException('Unauthorized access!');
-            }
+            $this->denyAccessUnlessGranted('view', $post, 'Unauthorized access!');
 
             return new Response('<h1>'.$post->getName().'</h1>');
         }
