Handle "constraints" option in form unit testing

sarcher · daFish · commit 3908ed2c6383 · 2014-09-26T19:52:16.000+02:00
In the current documentation, although a mocked `ValidatorInterface` is being passed to the `FormTypeValidatorExtension`, the actual `validate()` method in it is returning null. This causes any test against a form type that utilizes the extension's `constraints` option to fail, because of the following code in `Symfony\Component\Form\Extension\Validator\EventListener\ValidationListener`:

```php
            // Validate the form in group "Default"
            $violations = $this-&gt;validator-&gt;validate($form);

            foreach ($violations as $violation) {
                // Allow the "invalid" constraint to be put onto
                // non-synchronized forms
                $allowNonSynchronized = Form::ERR_INVALID === $violation-&gt;getCode();

                $this-&gt;violationMapper-&gt;mapViolation($violation, $form, $allowNonSynchronized);
            }
```

Note the `foreach` loop that is expecting an array.

Since the documentation uses the `ValidatorExtension` as a specific example, I think it would be nice for the example code to handle this case, preventing the user from having to dig deeper into the code to discover the problem.
diff --git a/cookbook/form/unit_testing.rst b/cookbook/form/unit_testing.rst
@@ -183,12 +183,15 @@ on other extensions. You need add those extensions to the factory object::
         protected function setUp()
         {
             parent::setUp();
+            
+            $validator = $this->getMock('\Symfony\Component\Validator\ValidatorInterface');
+            $validator->method('validate')->will($this->returnValue(array()));
 
             $this->factory = Forms::createFormFactoryBuilder()
                 ->addExtensions($this->getExtensions())
                 ->addTypeExtension(
                     new FormTypeValidatorExtension(
-                        $this->getMock('Symfony\Component\Validator\ValidatorInterface')
+                        $validator
                     )
                 )
                 ->addTypeGuesser(

Original file line number	Diff line number	Diff line change
`@@ -183,12 +183,15 @@ on other extensions. You need add those extensions to the factory object::`
`183`	`183`	`protected function setUp()`
`184`	`184`	`{`
`185`	`185`	`parent::setUp();`
	`186`	`+`
	`187`	`+ $validator = $this->getMock('\Symfony\Component\Validator\ValidatorInterface');`
	`188`	`+ $validator->method('validate')->will($this->returnValue(array()));`
`186`	`189`
`187`	`190`	`$this->factory = Forms::createFormFactoryBuilder()`
`188`	`191`	`->addExtensions($this->getExtensions())`
`189`	`192`	`->addTypeExtension(`
`190`	`193`	`new FormTypeValidatorExtension(`
`191`		`- $this->getMock('Symfony\Component\Validator\ValidatorInterface')`
	`194`	`+ $validator`
`192`	`195`	`)`
`193`	`196`	`)`
`194`	`197`	`->addTypeGuesser(`