bug #20403 [Security] Fix wrong method call of the decision manager (Oliver Kossin)

OskarStark · OskarStark · commit 5f1dda82879c · 2024-11-19T22:33:05.000+01:00
This PR was merged into the 5.4 branch. Discussion ---------- [Security] Fix wrong method call of the decision manager `@xabbuh` changed the use of “decision manage” in [PR-20388](#20388) However, the method is described differently in the [interface](https://github.com/symfony/symfony/blob/7.2/src/Symfony/Component/Security/Core/Authorization/AccessDecisionManagerInterface.php#L29). It's not `isGranted` its `decide` Commits ------- 97599f7 Fix isGranted to decide
diff --git a/security/impersonating_user.rst b/security/impersonating_user.rst
@@ -337,12 +337,12 @@ logic you want::
             }
 
             // you can still check for ROLE_ALLOWED_TO_SWITCH
-            if ($this->accessDecisionManager->isGranted($token, ['ROLE_ALLOWED_TO_SWITCH'])) {
+            if ($this->accessDecisionManager->decide($token, ['ROLE_ALLOWED_TO_SWITCH'])) {
                 return true;
             }
 
             // check for any roles you want
-            if ($this->accessDecisionManager->isGranted($token, ['ROLE_TECH_SUPPORT'])) {
+            if ($this->accessDecisionManager->decide($token, ['ROLE_TECH_SUPPORT'])) {
                 return true;
             }
 
diff --git a/security/voters.rst b/security/voters.rst
@@ -248,7 +248,7 @@ with ``ROLE_SUPER_ADMIN``::
             // ...
 
             // ROLE_SUPER_ADMIN can do anything! The power!
-            if ($this->accessDecisionManager->isGranted($token, ['ROLE_SUPER_ADMIN'])) {
+            if ($this->accessDecisionManager->decide($token, ['ROLE_SUPER_ADMIN'])) {
                 return true;
             }
 

Original file line number	Diff line number	Diff line change
`@@ -337,12 +337,12 @@ logic you want::`
`337`	`337`	`}`
`338`	`338`
`339`	`339`	`// you can still check for ROLE_ALLOWED_TO_SWITCH`
`340`		`- if ($this->accessDecisionManager->isGranted($token, ['ROLE_ALLOWED_TO_SWITCH'])) {`
	`340`	`+ if ($this->accessDecisionManager->decide($token, ['ROLE_ALLOWED_TO_SWITCH'])) {`
`341`	`341`	`return true;`
`342`	`342`	`}`
`343`	`343`
`344`	`344`	`// check for any roles you want`
`345`		`- if ($this->accessDecisionManager->isGranted($token, ['ROLE_TECH_SUPPORT'])) {`
	`345`	`+ if ($this->accessDecisionManager->decide($token, ['ROLE_TECH_SUPPORT'])) {`
`346`	`346`	`return true;`
`347`	`347`	`}`
`348`	`348`
Original file line number	Diff line number	Diff line change
@@ -248,7 +248,7 @@ with ``ROLE_SUPER_ADMIN``::
`248`	`248`	`// ...`
`249`	`249`
`250`	`250`	`// ROLE_SUPER_ADMIN can do anything! The power!`
`251`		`- if ($this->accessDecisionManager->isGranted($token, ['ROLE_SUPER_ADMIN'])) {`
	`251`	`+ if ($this->accessDecisionManager->decide($token, ['ROLE_SUPER_ADMIN'])) {`
`252`	`252`	`return true;`
`253`	`253`	`}`
`254`	`254`