Merge branch '3.4' into 4.3

javiereguiluz · javiereguiluz · commit 7096d5483ab8 · 2019-10-16T08:50:58.000+02:00
* 3.4:
  Fix EvolvableLink attribute
diff --git a/web_link.rst b/web_link.rst
@@ -170,7 +170,9 @@ You can also add links to the HTTP response directly from controllers and servic
 
             // alternative if you don't want to use the addLink() shortcut
             $linkProvider = $request->attributes->get('_links', new GenericLinkProvider());
-            $request->attributes->set('_links', $linkProvider->withLink(new Link('preload', '/app.css', ['as' : 'style'])));
+            $request->attributes->set('_links', $linkProvider->withLink(
+                (new Link('preload', '/app.css'))->withAttribute('as', 'style')
+            ));
 
             return $this->render('...');
         }

Original file line number	Diff line number	Diff line change
`@@ -170,7 +170,9 @@ You can also add links to the HTTP response directly from controllers and servic`
`170`	`170`
`171`	`171`	`// alternative if you don't want to use the addLink() shortcut`
`172`	`172`	`$linkProvider = $request->attributes->get('_links', new GenericLinkProvider());`
`173`		`- $request->attributes->set('_links', $linkProvider->withLink(new Link('preload', '/app.css', ['as' : 'style'])));`
	`173`	`+ $request->attributes->set('_links', $linkProvider->withLink(`
	`174`	`+ (new Link('preload', '/app.css'))->withAttribute('as', 'style')`
	`175`	`+ ));`
`174`	`176`
`175`	`177`	`return $this->render('...');`
`176`	`178`	`}`