Use of Setters and Getters

martin05 · weaverryan · commit 789ed438d6b6 · 2017-07-06T06:36:13.000-04:00
If I have already define getter for the $targetDir, I should use it.
diff --git a/controller/upload_file.rst b/controller/upload_file.rst
@@ -243,7 +243,7 @@ logic to a separate service::
         {
             $fileName = md5(uniqid()).'.'.$file->guessExtension();
 
-            $file->move($this->targetDir, $fileName);
+            $file->move($this->getTargetDir(), $fileName);
 
             return $fileName;
         }

Original file line number	Diff line number	Diff line change
`@@ -243,7 +243,7 @@ logic to a separate service::`
`243`	`243`	`{`
`244`	`244`	`$fileName = md5(uniqid()).'.'.$file->guessExtension();`
`245`	`245`
`246`		`- $file->move($this->targetDir, $fileName);`
	`246`	`+ $file->move($this->getTargetDir(), $fileName);`
`247`	`247`
`248`	`248`	`return $fileName;`
`249`	`249`	`}`