Skip to content

Commit b20c28a

Browse files
committed
Merge branch '4.4' into 5.4
* 4.4: remove outdated references to the master branch [Form] Fix undefined variable
2 parents d3a43d9 + db2e2ea commit b20c28a

File tree

4 files changed

+14
-14
lines changed

4 files changed

+14
-14
lines changed

_build/maintainer_guide.rst

+3-3
Original file line numberDiff line numberDiff line change
@@ -39,22 +39,22 @@ contributes again, it's OK to mention some of the minor issues to educate them.
3939
4040
$ gh merge 11059
4141
42-
Working on symfony/symfony-docs (branch master)
42+
Working on symfony/symfony-docs (branch 5.4)
4343
Merging Pull Request 11059: dmaicher/patch-3
4444
4545
...
4646
4747
# This is important!! Say NO to push the changes now
4848
Push the changes now? (Y/n) n
49-
Now, push with: git push gh "master" refs/notes/github-comments
49+
Now, push with: git push gh "5.4" refs/notes/github-comments
5050
5151
# Now, open your editor and make the needed changes ...
5252
5353
$ git commit -a
5454
# Use "Minor reword", "Minor tweak", etc. as the commit message
5555
5656
# now run the 'push' command shown above by 'gh' (it's different each time)
57-
$ git push gh "master" refs/notes/github-comments
57+
$ git push gh "5.4" refs/notes/github-comments
5858
5959
Merging Pull Requests
6060
---------------------

contributing/code/maintenance.rst

+4-4
Original file line numberDiff line numberDiff line change
@@ -41,14 +41,14 @@ Besides bug fixes, other minor changes can be accepted in a patch version:
4141

4242
* **Coding standard and refactoring**: Coding standard fixes or code
4343
refactoring are not recommended but can be accepted for consistency with the
44-
existing code base, if they are not too invasive, and if merging them on
45-
master would not lead to complex branch merging;
44+
existing code base, if they are not too invasive, and if merging them into
45+
higher branches would not lead to complex branch merging;
4646

4747
* **Tests**: Tests that increase the code coverage can be added.
4848

4949
Anything not explicitly listed above should be done on the next minor or major
50-
version instead (aka the *master* branch). For instance, the following changes
51-
are never accepted in a patch version:
50+
version instead. For instance, the following changes are never accepted in a
51+
patch version:
5252

5353
* **New features**;
5454

contributing/documentation/format.rst

+6-6
Original file line numberDiff line numberDiff line change
@@ -201,12 +201,12 @@ For a deprecation use the ``.. deprecated:: 5.x`` directive:
201201
202202
... ... ... was deprecated in Symfony 5.2.
203203
204-
Whenever a new major version of Symfony is released (e.g. 6.0, 7.0, etc),
205-
a new branch of the documentation is created from the ``master`` branch.
206-
At this point, all the ``versionadded`` and ``deprecated`` tags for Symfony
207-
versions that have a lower major version will be removed. For example, if
208-
Symfony 6.0 were released today, 5.0 to 5.4 ``versionadded`` and ``deprecated``
209-
tags would be removed from the new ``6.0`` branch.
204+
Whenever a new major version of Symfony is released (e.g. 6.0, 7.0, etc), a new
205+
branch of the documentation is created from the ``x.4`` branch of the previous
206+
major version. At this point, all the ``versionadded`` and ``deprecated`` tags
207+
for Symfony versions that have a lower major version will be removed. For
208+
example, if Symfony 6.0 were released today, 5.0 to 5.4 ``versionadded`` and
209+
``deprecated`` tags would be removed from the new ``6.0`` branch.
210210

211211
.. _reStructuredText: https://docutils.sourceforge.io/rst.html
212212
.. _Sphinx: https://www.sphinx-doc.org/

form/unit_testing.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ The simplest ``TypeTestCase`` implementation looks like the following::
5959
$form = $this->factory->create(TestedType::class, $model);
6060

6161
$expected = new TestObject();
62-
// ...populate $object properties with the data stored in $formData
62+
// ...populate $expected properties with the data stored in $formData
6363

6464
// submit the data to the form directly
6565
$form->submit($formData);

0 commit comments

Comments
 (0)