Merge branch '2.3' into 2.4

weaverryan · weaverryan · commit bbfdb214b138 · 2014-05-12T10:59:09.000-05:00
diff --git a/components/console/helpers/dialoghelper.rst b/components/console/helpers/dialoghelper.rst
@@ -117,6 +117,7 @@ method::
                     'The name of the bundle should be suffixed with \'Bundle\''
                 );
             }
+
             return $answer;
         },
         false,
@@ -156,9 +157,11 @@ You can also ask and validate a hidden response::
     $dialog = $this->getHelperSet()->get('dialog');
 
     $validator = function ($value) {
-        if (trim($value) == '') {
+        if ('' === trim($value)) {
             throw new \Exception('The password can not be empty');
         }
+        
+        return $value;
     };
 
     $password = $dialog->askHiddenResponseAndValidate(
diff --git a/components/http_foundation/sessions.rst b/components/http_foundation/sessions.rst
@@ -12,6 +12,12 @@ object-oriented interface using a variety of session storage drivers.
 Sessions are used via the simple :class:`Symfony\\Component\\HttpFoundation\\Session\\Session`
 implementation of :class:`Symfony\\Component\\HttpFoundation\\Session\\SessionInterface` interface.
 
+.. caution::
+
+    Make sure your PHP session isn't already started before using the Session
+    class. If you have a legacy session system that starts your session, see
+    http://symfony.com/doc/current/components/http_foundation/session_php_bridge.html
+
 Quick example::
 
     use Symfony\Component\HttpFoundation\Session\Session;
diff --git a/components/routing/hostname_pattern.rst b/components/routing/hostname_pattern.rst
@@ -282,3 +282,19 @@ You can also set the host option on imported routes:
 
 The host ``hello.example.com`` will be set on each route loaded from the new
 routing resource.
+
+Testing your Controllers
+------------------------
+
+You need to set the Host HTTP header on your request objects if you want to get
+past url matching in your functional tests.
+
+ .. code-block:: php
+
+     $crawler = $client->request(
+         'GET',
+         '/homepage',
+         array(),
+         array(),
+         array('HTTP_HOST' => 'm.' . $client->getContainer()->getParameter('domain'))
+     );
