minor #6141 Docs do not match functionality (Loupax)

xabbuh · xabbuh · commit cc8e4366ea35 · 2016-01-29T17:30:10.000+01:00
This PR was submitted for the 3.0 branch but it was merged into the 2.3 branch instead (closes #6141). Discussion ---------- Docs do not match functionality | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 3 | Fixed tickets | None The Dump the configuration section specifies that one of the requirements that need to be met to automatically dump configuration is the constructor not requiring parameters. The code that handles this though does not match this description: ``` /** * {@inheritdoc} */ public function getConfiguration(array $config, ContainerBuilder $container) { $reflected = new \ReflectionClass($this); $namespace = $reflected->getNamespaceName(); $class = $namespace.'\\Configuration'; if (class_exists($class)) { $r = new \ReflectionClass($class); $container->addResource(new FileResource($r->getFileName())); // Notice here that it just checks if the __construct method exists, // the arguments are irrelevant if (!method_exists($class, '__construct')) { $configuration = new $class(); return $configuration; } } } ``` Commits ------- 739e23a Docs do not match functionality
diff --git a/cookbook/bundles/configuration.rst b/cookbook/bundles/configuration.rst
@@ -294,8 +294,8 @@ The ``config:dump-reference`` command dumps the default configuration of a
 bundle in the console using the Yaml format.
 
 As long as your bundle's configuration is located in the standard location
-(``YourBundle\DependencyInjection\Configuration``) and does not require
-arguments to be passed to the constructor it will work automatically. If you
+(``YourBundle\DependencyInjection\Configuration``) and does not have
+a constructor it will work automatically. If you
 have something different, your ``Extension`` class must override the
 :method:`Extension::getConfiguration() <Symfony\\Component\\HttpKernel\\DependencyInjection\\Extension::getConfiguration>`
 method and return an instance of your ``Configuration``.
