Skip to content

Commit d2736bc

Browse files
wouterjwouterj
committed
Yet another great review!
1 parent eed64a8 commit d2736bc

File tree

2 files changed

+20
-20
lines changed

2 files changed

+20
-20
lines changed

‎translation.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -183,7 +183,7 @@ using the ``trans()`` method:
183183
resources defined for the ``locale`` (e.g. ``fr_FR``). Messages from the
184184
:ref:`fallback locale <translation-fallback>` are also loaded and
185185
added to the catalog if they don't already exist. The end result is a large
186-
"dictionary" of translations. This catalog is cached in production, to
186+
"dictionary" of translations. This catalog is cached in production to
187187
minimize performance impact.
188188

189189
* If the message is located in the catalog, the translation is returned. If

‎translation/message_format.rst

+19-19
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ Using the ICU Message Format
2020
----------------------------
2121

2222
In order to use the ICU Message Format, the :ref:`message domain
23-
<using-message-domains>` has to be suffixed with ``intl-icu``:
23+
<using-message-domains>` has to be suffixed with ``+intl-icu``:
2424

2525
====================== ===============================
2626
Normal file name ICU Message Format filename
@@ -45,12 +45,12 @@ The basic usage of the MessageFormat allows you to use placeholders (called
4545

4646
.. code-block:: yaml
4747
48-
# translations/messages.en.yaml
48+
# translations/messages+intl-icu.en.yaml
4949
say_hello: 'Hello {name}!'
5050
5151
.. code-block:: xml
5252
53-
<!-- translations/messages.en.xlf -->
53+
<!-- translations/messages+intl-icu.en.xlf -->
5454
<?xml version="1.0"?>
5555
<xliff version="1.2" xmlns="urn:oasis:names:tc:xliff:document:1.2">
5656
<file source-language="en" datatype="plaintext" original="file.ext">
@@ -65,7 +65,7 @@ The basic usage of the MessageFormat allows you to use placeholders (called
6565
6666
.. code-block:: php
6767
68-
// translations/messages.en.php
68+
// translations/messages+intl-icu.en.php
6969
return [
7070
'say_hello' => "Hello {name}!",
7171
];
@@ -91,7 +91,7 @@ typical usage of this is gender:
9191

9292
.. code-block:: yaml
9393
94-
# translations/messages.en.yaml
94+
# translations/messages+intl-icu.en.yaml
9595
invitation_title: >
9696
{organizer_gender, select,
9797
female {{organizer_name} has invited you for her party!}
@@ -101,7 +101,7 @@ typical usage of this is gender:
101101
102102
.. code-block:: xml
103103
104-
<!-- translations/messages.en.xlf -->
104+
<!-- translations/messages+intl-icu.en.xlf -->
105105
<?xml version="1.0"?>
106106
<xliff version="1.2" xmlns="urn:oasis:names:tc:xliff:document:1.2">
107107
<file source-language="en" datatype="plaintext" original="file.ext">
@@ -116,7 +116,7 @@ typical usage of this is gender:
116116
117117
.. code-block:: php
118118
119-
// translations/messages.en.php
119+
// translations/messages+intl-icu.en.php
120120
return [
121121
'invitation_title' => '{organizer_gender, select,
122122
female {{organizer_name} has invited you for her party!}
@@ -172,7 +172,7 @@ handle pluralization in your messages (e.g. ``There are 3 apples`` vs
172172

173173
.. code-block:: yaml
174174
175-
# translations/messages.en.yaml
175+
# translations/messages+intl-icu.en.yaml
176176
num_of_apples: >
177177
{apples, plural,
178178
=0 {There are no apples}
@@ -182,7 +182,7 @@ handle pluralization in your messages (e.g. ``There are 3 apples`` vs
182182
183183
.. code-block:: xml
184184
185-
<!-- translations/messages.en.xlf -->
185+
<!-- translations/messages+intl-icu.en.xlf -->
186186
<?xml version="1.0"?>
187187
<xliff version="1.2" xmlns="urn:oasis:names:tc:xliff:document:1.2">
188188
<file source-language="en" datatype="plaintext" original="file.ext">
@@ -197,7 +197,7 @@ handle pluralization in your messages (e.g. ``There are 3 apples`` vs
197197
198198
.. code-block:: php
199199
200-
// translations/messages.en.php
200+
// translations/messages+intl-icu.en.php
201201
return [
202202
'num_of_apples' => '{apples, plural,
203203
=0 {There are no apples}
@@ -277,7 +277,7 @@ Similar to ``plural``, ``selectordinal`` allows you to use numbers as ordinal sc
277277

278278
.. code-block:: yaml
279279
280-
# translations/messages.en.yaml
280+
# translations/messages+intl-icu.en.yaml
281281
finish_place: >
282282
You finished {place, selectordinal,
283283
one {#st}
@@ -292,7 +292,7 @@ Similar to ``plural``, ``selectordinal`` allows you to use numbers as ordinal sc
292292
293293
.. code-block:: xml
294294
295-
<!-- translations/messages.en.xlf -->
295+
<!-- translations/messages+intl-icu.en.xlf -->
296296
<?xml version="1.0"?>
297297
<xliff version="1.2" xmlns="urn:oasis:names:tc:xliff:document:1.2">
298298
<file source-language="en" datatype="plaintext" original="file.ext">
@@ -314,7 +314,7 @@ Similar to ``plural``, ``selectordinal`` allows you to use numbers as ordinal sc
314314
315315
.. code-block:: php
316316
317-
// translations/messages.en.php
317+
// translations/messages+intl-icu.en.php
318318
return [
319319
'finish_place' => 'You finished {place, selectordinal,
320320
one {#st}
@@ -351,12 +351,12 @@ using the :phpclass:`IntlDateFormatter`:
351351

352352
.. code-block:: yaml
353353
354-
# translations/messages.en.yaml
354+
# translations/messages+intl-icu.en.yaml
355355
published_at: 'Published at {publication_date, date} - {publication_date, time, short}'
356356
357357
.. code-block:: xml
358358
359-
<!-- translations/messages.en.xlf -->
359+
<!-- translations/messages+intl-icu.en.xlf -->
360360
<?xml version="1.0"?>
361361
<xliff version="1.2" xmlns="urn:oasis:names:tc:xliff:document:1.2">
362362
<file source-language="en" datatype="plaintext" original="file.ext">
@@ -371,7 +371,7 @@ using the :phpclass:`IntlDateFormatter`:
371371
372372
.. code-block:: php
373373
374-
// translations/messages.en.php
374+
// translations/messages+intl-icu.en.php
375375
return [
376376
'published_at' => 'Published at {publication_date, date} - {publication_date, time, short}',
377377
];
@@ -393,13 +393,13 @@ The ``number`` formatter allows you to format numbers using Intl's :phpclass:`Nu
393393

394394
.. code-block:: yaml
395395
396-
# translations/messages.en.yaml
396+
# translations/messages+intl-icu.en.yaml
397397
progress: '{progress, number, percent} of the work is done'
398398
value_of_object: 'This artifact is worth {value, number, currency}'
399399
400400
.. code-block:: xml
401401
402-
<!-- translations/messages.en.xlf -->
402+
<!-- translations/messages+intl-icu.en.xlf -->
403403
<?xml version="1.0"?>
404404
<xliff version="1.2" xmlns="urn:oasis:names:tc:xliff:document:1.2">
405405
<file source-language="en" datatype="plaintext" original="file.ext">
@@ -419,7 +419,7 @@ The ``number`` formatter allows you to format numbers using Intl's :phpclass:`Nu
419419
420420
.. code-block:: php
421421
422-
// translations/messages.en.php
422+
// translations/messages+intl-icu.en.php
423423
return [
424424
'progress' => '{progress, number, percent} of the work is done',
425425
'value_of_object' => 'This artifact is worth {value, number, currency}',

0 commit comments

Comments
 (0)