Skip to content

Commit d61c3c3

Browse files
committed
Merge branch '2.1' into 2.2
2 parents 2f01d10 + 473c727 commit d61c3c3

File tree

5 files changed

+14
-31
lines changed

5 files changed

+14
-31
lines changed

components/dependency_injection/parentservices.rst

+4-25
Original file line numberDiff line numberDiff line change
@@ -312,26 +312,15 @@ to the ``NewsletterManager`` class, the config would look like this:
312312
mail_manager:
313313
abstract: true
314314
calls:
315-
<<<<<<< HEAD
316-
- [ setMailer, [ @my_mailer ] ]
317-
- [ setEmailFormatter, [ @my_email_formatter] ]
318-
319-
=======
320315
- [setMailer, ["@my_mailer"]]
321316
- [setEmailFormatter, ["@my_email_formatter"]]
322-
323-
>>>>>>> e1ae126cb094754b7f4e72bbdb4388fed7f2d188
317+
324318
newsletter_manager:
325319
class: "%newsletter_manager.class%"
326320
parent: mail_manager
327321
calls:
328-
<<<<<<< HEAD
329-
- [ setMailer, [ @my_alternative_mailer ] ]
330-
331-
=======
332322
- [setMailer, ["@my_alternative_mailer"]]
333-
334-
>>>>>>> e1ae126cb094754b7f4e72bbdb4388fed7f2d188
323+
335324
greeting_card_manager:
336325
class: "%greeting_card_manager.class%"
337326
parent: mail_manager
@@ -450,24 +439,14 @@ If you had the following config:
450439
mail_manager:
451440
abstract: true
452441
calls:
453-
<<<<<<< HEAD
454-
- [ setFilter, [ @my_filter ] ]
455-
456-
=======
457442
- [setFilter, ["@my_filter"]]
458-
459-
>>>>>>> e1ae126cb094754b7f4e72bbdb4388fed7f2d188
443+
460444
newsletter_manager:
461445
class: "%newsletter_manager.class%"
462446
parent: mail_manager
463447
calls:
464-
<<<<<<< HEAD
465-
- [ setFilter, [ @another_filter ] ]
466-
467-
=======
468448
- [setFilter, ["@another_filter"]]
469-
470-
>>>>>>> e1ae126cb094754b7f4e72bbdb4388fed7f2d188
449+
471450
.. code-block:: xml
472451
473452
<parameters>

components/http_foundation/introduction.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -200,7 +200,7 @@ a Request::
200200
The :method:`Symfony\\Component\\HttpFoundation\\Request::create` method
201201
creates a request based on a path info, a method and some parameters (the
202202
query parameters or the request ones depending on the HTTP method); and of
203-
course, you an also override all other variables as well (by default, Symfony
203+
course, you can also override all other variables as well (by default, Symfony
204204
creates sensible defaults for all the PHP global variables).
205205

206206
Based on such a request, you can override the PHP global variables via

components/process.rst

+2-2
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ a command in a sub-process::
2626
$process = new Process('ls -lsa');
2727
$process->run();
2828

29-
// executes after the the command finishes
29+
// executes after the command finishes
3030
if (!$process->isSuccessful()) {
3131
throw new \RuntimeException($process->getErrorOutput());
3232
}
@@ -86,7 +86,7 @@ are done doing other stuff::
8686
$process = new Process('ls -lsa');
8787
$process->start();
8888
89-
// do other things
89+
// ... do other things
9090
9191
$process->wait(function ($type, $buffer) {
9292
if ('err' === $type) {

contributing/code/security.rst

+1-1
Original file line numberDiff line numberDiff line change
@@ -75,5 +75,5 @@ releases, starting from Symfony 1.0.0:
7575
* June 25, 2007: `symfony 1.0.5 released (security fix) <http://symfony.com/blog/symfony-1-0-5-released-security-fix>`_
7676

7777
.. _Git repository: https://github.com/symfony/symfony
78-
.. _blog: https://symfony.com/blog/
78+
.. _blog: http://symfony.com/blog/
7979
.. _Security Advisories: http://symfony.com/blog/category/security-advisories

contributing/code/standards.rst

+6-2
Original file line numberDiff line numberDiff line change
@@ -72,6 +72,8 @@ example containing most features described below:
7272
} else {
7373
$dummy = ucwords($dummy);
7474
}
75+
} else {
76+
throw new \RuntimeException(sprintf('Unrecognized dummy option "%s"', $dummy));
7577
}
7678

7779
return $dummy;
@@ -100,10 +102,12 @@ Structure
100102

101103
* Declare class properties before methods;
102104

103-
* Declare public methods first, then protected ones and finally private ones.
105+
* Declare public methods first, then protected ones and finally private ones;
104106

105107
* Use parentheses when instantiating classes regardless of the number of
106-
arguments the constructor has.
108+
arguments the constructor has;
109+
110+
* Exception message strings should be concatenated using :phpfunction:`sprintf`.
107111

108112
Naming Conventions
109113
------------------

0 commit comments

Comments
 (0)