Skip to content

Twig cache documentation shows using null instead of false #10101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nesl247 opened this issue Jul 19, 2018 · 2 comments
Closed

Twig cache documentation shows using null instead of false #10101

nesl247 opened this issue Jul 19, 2018 · 2 comments
Labels
bug Status: Needs Review Twig
Milestone
2.8

Comments

@nesl247
Copy link
Contributor

nesl247 commented Jul 19, 2018

https://github.com/symfony/symfony-docs/blob/master/reference/configuration/twig.rst#cache shows that we need to specify null if we want to disable cache. However, https://github.com/twigphp/Twig/blob/60a8f465d6f259c92a8fe0fb61cf8f767bd8d025/lib/Twig/Environment.php#L247 states that we need false instead.

Also, the type is either string|bool|Twig_CacheInterface. I'm not sure if the docs support multi-types though.
@nesl247 nesl247 mentioned this issue Jul 19, 2018
Closed
@javiereguiluz javiereguiluz added this to the 2.8 milestone Jul 20, 2018
@javiereguiluz javiereguiluz mentioned this issue Jul 20, 2018
Merged
javiereguiluz added a commit that referenced this issue Jul 20, 2018
@javiereguiluz
minor #10102 Fixed the type of the twig.cache config option (javiereg…
0b8c2ae 
…uiluz)

This PR was merged into the 2.8 branch.

Discussion
----------

Fixed the type of the twig.cache config option

Fixes #10101.

Commits
-------

0a2c44f Fixed the type of the twig.cache config option
@javiereguiluz
Copy link
Member

Fixed by #10102.

@nesl247
Copy link
Contributor Author

nesl247 commented Jul 20, 2018

Thanks @javiereguiluz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Status: Needs Review Twig
Projects
None yet
Milestone
2.8
Development

No branches or pull requests
3 participants
@javiereguiluz @nesl247 @carsonbot