Skip to content

[FrameworkBundle] Deprecate auto-injection of the container in AbstractController instances #10342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
javiereguiluz opened this issue Sep 13, 2018 · 1 comment
Closed

[FrameworkBundle] Deprecate auto-injection of the container in AbstractController instances #10342

javiereguiluz opened this issue Sep 13, 2018 · 1 comment
Labels
deprecation FrameworkBundle
Milestone
4.2

Comments

@javiereguiluz
Copy link
Member

symfony/symfony#27462
@javiereguiluz javiereguiluz added this to the 4.2 milestone Sep 13, 2018
@javiereguiluz
Copy link
Member Author

Closing as fixed. We updated all controller examples to always extend from AbstractController and to never show the $this->get() shortcut. We even mention explicitly in some articles that you must inject services because controllers extending from AbstractController don't have access to the service container.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
deprecation FrameworkBundle
Projects
None yet
Milestone
4.2
Development

No branches or pull requests
1 participant
@javiereguiluz