Skip to content

[Intl] Renamed Regions to Countries #11532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javiereguiluz opened this issue May 7, 2019 · 3 comments
Closed

[Intl] Renamed Regions to Countries #11532

javiereguiluz opened this issue May 7, 2019 · 3 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Intl
Milestone

Comments

@javiereguiluz
Copy link
Member

I still think it's a big mistake 😢 but we'll need to update the current docs: symfony/symfony#31350

@javiereguiluz javiereguiluz added this to the 4.3 milestone May 7, 2019
@ro0NL
Copy link
Contributor

ro0NL commented May 9, 2019

Hi @javiereguiluz, thanks for taken care here :)

I understand your POV about regions vs. countries, but we need something to reason about.

Regions: world, (sub-continents), "countries/terroritories"
Countries: ISO 3166-1 alpha-2 (officially assigned)

For the docs it could be worth clarifying what we mean when we use "country".

The main reason for the PR was, it directly affects CountryType/CountryValidator. Discussing the naming should be done across the board IMHO.

Moreover, ICU itself uses "countries" as a term for all regions: https://github.com/unicode-org/icu/blob/master/icu4c/source/data/region/en.txt#L4 🤷‍♂️

Moreover, after we excluded numeric codes (continents) and a few "non officially-assigned country codes" the list got ISO 3166-1 alpha-2 compliant, which to me proves ICU follows the same ISO standards.

@javiereguiluz
Copy link
Member Author

I still think that the best solution is to use the ICO list of "Countries" + "Territories" and call that "Regions".

In the list of ISO "countries" you can find "jokes" like this: Bouvet Island. It's NOT a country and 0 people live there.

@ro0NL
Copy link
Contributor

ro0NL commented May 9, 2019

That could be worth considering, at least the current data set is OK now. Leaving us with a naming issue then.

Im fine with "country", so i'll leave this RFC proposal up to you. I think "country" is the most common/recognizable term in general, and conforms with upstream references let's say: https://en.wikipedia.org/wiki/List_of_ISO_3166_country_codes

@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label May 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hasPR A Pull Request has already been submitted for this issue. Intl
Projects
None yet
Development

No branches or pull requests

2 participants