Skip to content

[FrameworkBundle] add attribute stamps #11768

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabpot opened this issue Jun 18, 2019 · 8 comments
Closed

[FrameworkBundle] add attribute stamps #11768

fabpot opened this issue Jun 18, 2019 · 8 comments

Comments

@fabpot
Copy link
Member

fabpot commented Jun 18, 2019

Q A
Feature PR symfony/symfony#31764
PR author(s) @walidboughdiri
Merged in 4.4
@LS05
Copy link
Contributor

LS05 commented Jul 6, 2019

Hi! Can I contribute to this issue?

@OskarStark
Copy link
Contributor

Yes you can 👍🏻

@LS05
Copy link
Contributor

LS05 commented Jul 7, 2019

I have a couple of questions.

Do you mind explaining what does Add docs for mean in practical terms? 😄
Does it mean that this file needs to be changed? Or does it refer to the PHPDoc block?

Thank you!

@xabbuh
Copy link
Member

xabbuh commented Jul 11, 2019

@LS05 (Almost) all issues in this repository refer to the files managed in this repository and not docblock comments. :) As far as I can see the only place where we mention the updated method is in the messenger.rst file where we could document this change.

@LS05
Copy link
Contributor

LS05 commented Jul 17, 2019

I see stamps are documented here: https://github.com/symfony/symfony-docs/blob/cef0d2b66970938958a729f49fe777bf211742b8/components/messenger.rst#adding-metadata-to-messages-envelopes

IMO 😄there's an extensive documentation. Am I looking at the right place?

@OskarStark OskarStark added this to the 4.4 milestone Jul 23, 2019
@OskarStark OskarStark changed the title Add docs for: [FrameworkBundle] add attribute stamps [FrameworkBundle] add attribute stamps Jul 23, 2019
@carsonbot
Copy link
Collaborator

Thank you for this issue.
There has not been a lot of activity here for a while. Has this been resolved?

@carsonbot
Copy link
Collaborator

Hello? This issue is about to be closed if nobody replies.

@carsonbot
Copy link
Collaborator

Hey,

I didn't hear anything so I'm going to close it. Feel free to comment if this is still relevant, I can always reopen!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants