Skip to content

Repeated entry in the Serializer components doc #11786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
javiereguiluz opened this issue Jun 19, 2019 · 0 comments
Closed

Repeated entry in the Serializer components doc #11786

javiereguiluz opened this issue Jun 19, 2019 · 0 comments

Comments

@javiereguiluz
Copy link
Member

Thanks to the new "table of contents" displayed for articles, we received a report in the Symfony Slack about the repeated "XML Encoder" entry in this article: https://symfony.com/doc/current/components/serializer.html

armin-github added a commit to armin-github/symfony-docs that referenced this issue Feb 27, 2020
The following issue has been addressed: Repeated entry in the Serializer components doc symfony#11786 
The separate documentations for XMLEncoder were put into one section with minor changes in text. The documentation now contains one single section for XMLEncoder.
wouterj pushed a commit to armin-github/symfony-docs that referenced this issue Nov 5, 2020
The following issue has been addressed: Repeated entry in the Serializer components doc symfony#11786
The separate documentations for XMLEncoder were put into one section with minor changes in text. The documentation now contains one single section for XMLEncoder.
wouterj added a commit that referenced this issue Nov 5, 2020
This PR was submitted for the 5.0 branch but it was merged into the 4.4 branch instead.

Discussion
----------

addressed issue #11786

The following issue has been addressed: Repeated entry in the Serializer components doc #11786
The separate documentations for XMLEncoder were put into one section with minor changes in text. The documentation now contains one single section for XMLEncoder.

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/roadmap for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `master` for features of unreleased versions).

-->

Commits
-------

0163ab3 addressed issue #11786
wouterj added a commit that referenced this issue Nov 5, 2020
* 4.4:
  addressed issue #11786
  Add array example on ChoiceType choice_attr option
  [#14340] Some minor textual changes
  [Collection forms] Make javascript generic
  Updating the Installer Related Instructions
wouterj added a commit that referenced this issue Nov 5, 2020
* 5.1:
  addressed issue #11786
  Add array example on ChoiceType choice_attr option
  [#13619] Moved text into a note and added versionadded
  Add wither behavior with PHP8 static return type
  [#14340] Some minor textual changes
  [Collection forms] Make javascript generic
  Updating the Installer Related Instructions
  Non-standard adder/remover methods
@wouterj wouterj closed this as completed Nov 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants