Skip to content

[Cache] Added reserved characters constant for CacheItem #12298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Sep 11, 2019 · 1 comment
Closed

[Cache] Added reserved characters constant for CacheItem #12298

fabpot opened this issue Sep 11, 2019 · 1 comment
Labels
Cache
Milestone
4.4

Comments

@fabpot
Copy link
Member

fabpot commented Sep 11, 2019

Q A
Feature PR symfony/symfony#33516
PR author(s) @andyexeter
Merged in 4.4
@javiereguiluz javiereguiluz added this to the 4.4 milestone Sep 12, 2019
@javiereguiluz
Copy link
Member

I think it's better to not document this new constant because the error message is very clear (see https://github.com/symfony/symfony/pull/33516/files) and the discoverability of the public constant should be high. We can reconsider his if we receive reports in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Cache
Projects
None yet
Milestone
4.4
Development

No branches or pull requests
2 participants
@fabpot @javiereguiluz