Skip to content

Provides a way to override cache and log folders from the ENV #13787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fabpot opened this issue Jun 9, 2020 · 3 comments
Closed

Provides a way to override cache and log folders from the ENV #13787

fabpot opened this issue Jun 9, 2020 · 3 comments
Milestone

Comments

@fabpot
Copy link
Member

fabpot commented Jun 9, 2020

Q A
Feature PR symfony/symfony#37114
PR author(s) @Plopix
Merged in 5.2-dev
@xabbuh xabbuh added this to the 5.2 milestone Jun 9, 2020
@Plopix
Copy link
Contributor

Plopix commented Jun 9, 2020

I can help here if someone points where you would like to add this quick documentation.

@javiereguiluz
Copy link
Member

@Plopix thanks! I think the best place would be in configuration/override_dir_structure.rst showing this as another option to override both cache and log dirs.

javiereguiluz added a commit that referenced this issue Jun 13, 2020
…e ENV (Plopix)

This PR was merged into the master branch.

Discussion
----------

Provides a way to override cache and log folders from the ENV

Related to this new feature symfony/symfony#37114.

But I wonder if we have not oversimplified this PR: symfony/symfony#37114

Actually doing the documentation #13787 I figured that with #37114 we removed the important split per `env`.

In development mode (docker or not) we could definitely have the same project working in N Symfony different environments and this new `APP_CACHE_DIR` will only set the same path for all environments.

That would be manageable in the Virtualhost but in CLI that would be a pain to manage.
Also, we could rely on the DotEnv mechanism, but that could be really easy to forget.

I wonder if we should not change the code to: symfony/symfony#37232

Depending on the decisions I will update the doc here.

Commits
-------

88b081c Provides a way to override cache and log folders from the ENV
@javiereguiluz
Copy link
Member

Fixed in #13819.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants