Skip to content

PHPUnit Bridge SetUpTearDownTrait got removed in 6.0 #16857

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mvhirsch opened this issue Jun 9, 2022 · 2 comments · Fixed by #16860
Closed

PHPUnit Bridge SetUpTearDownTrait got removed in 6.0 #16857

mvhirsch opened this issue Jun 9, 2022 · 2 comments · Fixed by #16860
Labels
hasPR A Pull Request has already been submitted for this issue. PHPUnitBridge
Milestone
5.4

Comments

@mvhirsch
Copy link
Contributor

mvhirsch commented Jun 9, 2022

The mentioned Trait got removed in 6.0 (symfony/symfony#41302). I suggest the whole paragraph can be removed in 6.0 and higher, too?

See: https://symfony.com/doc/6.0/components/phpunit_bridge.html#removing-the-void-return-type
@javiereguiluz javiereguiluz added this to the 5.4 milestone Jun 9, 2022
@javiereguiluz javiereguiluz mentioned this issue Jun 9, 2022
Merged
@javiereguiluz
Copy link
Member

Michael, thanks for your issue report, which contained all the needed information and references. It was perfect!

I propose to fix this in two ways: in #16860 we're adding the deprecation notice in 5.4 branch ... and when merging this into upper branches, we'll remove the paragraph entirely, as you proposed. Thanks!

@mvhirsch
Copy link
Contributor Author

That's the reason why I love the symfony community: efficient, friendly, ... please stay like this @javiereguiluz !

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
hasPR A Pull Request has already been submitted for this issue. PHPUnitBridge
Projects
None yet
Milestone
5.4
Development

Successfully merging a pull request may close this issue.

[PHPUnitBridge] Mention the SetUpTearDownTrait deprecation javiereguiluz/symfony-docs
3 participants
@javiereguiluz @mvhirsch @xabbuh