Skip to content

[Notifier] Add SMS options to ContactEveryone notifier #18310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nicolas-grekas opened this issue May 12, 2023 · 1 comment
Closed

[Notifier] Add SMS options to ContactEveryone notifier #18310

nicolas-grekas opened this issue May 12, 2023 · 1 comment
Labels
Notifier
Milestone
6.3

Comments

@nicolas-grekas
Copy link
Member

Q A
Feature PR symfony/symfony#48584
PR author(s) @gnito-org
Merged in 6.3

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 6.3 branch in the symfony-docs repository.

Thank you! 😃
@nicolas-grekas nicolas-grekas added this to the 6.3 milestone May 12, 2023
@alamirault alamirault mentioned this issue May 16, 2023
Merged
nicolas-grekas added a commit to symfony/symfony that referenced this issue May 20, 2023
@nicolas-grekas
bug #50349 [Notifier] Document Notifier options in README files (alam…
746c06b 
…irault)

This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[Notifier] Document Notifier options in README files

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

This PR add missing `*Options` documentations in notifier bridges readme

Documented bridges are:
- AllMySMS symfony/symfony-docs#18315
- ContactEveryone symfony/symfony-docs#18310
- Essendex symfony/symfony-docs#18308
- GatewayApi symfony/symfony-docs#18313
- MessageBird symfony/symfony-docs#18311
- MessageMedia symfony/symfony-docs#18312
- Twilio
- Termii

Waiting your feedback 😄

I will create another PR for AmazonSnsOptions, BandwidthOptions, ClickSendOptions, MobytOptions, PlivoOptions, RingCentralOptions, SmsmodeOptions, TwilioOptions after this one

Commits
-------

6153f04 [Notifier] Document Notifier options in README files
@javiereguiluz
Copy link
Member

Closing as documented in symfony/symfony#50349

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Notifier
Projects
None yet
Milestone
6.3
Development

No branches or pull requests
3 participants
@javiereguiluz @nicolas-grekas @carsonbot