Skip to content

[Config] Allow custom meta location in ResourceCheckerConfigCache #19496

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Feb 3, 2024 · 2 comments
Closed

[Config] Allow custom meta location in ResourceCheckerConfigCache #19496

fabpot opened this issue Feb 3, 2024 · 2 comments
Labels
Config hasPR A Pull Request has already been submitted for this issue.
Milestone
7.1

Comments

@fabpot
Copy link
Member

fabpot commented Feb 3, 2024

Q A
Feature PR symfony/symfony#52043
PR author(s) @ruudk
Merged in 7.1

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.1 branch in the symfony-docs repository.

Thank you! 😃
@fabpot fabpot added this to the 7.1 milestone Feb 3, 2024
@alamirault
Copy link
Contributor

alamirault commented Feb 4, 2024 •
edited
Loading

Only ConfigCache is documented in components/config/caching.rst

However metaFile was not added toConfigCache construct (which extends ResourceCheckerConfigCache), should we update this class in symfony source code ?

@alamirault
Copy link
Contributor

I created symfony/symfony#53868 to also allow to configure meta file in ConfigCache

@alamirault alamirault mentioned this issue Feb 9, 2024
Merged
OskarStark added a commit that referenced this issue Feb 12, 2024
@OskarStark
feature #19543 [Config] Allow custom meta location in ConfigCache (al…
9804422 
…amirault)

This PR was merged into the 7.1 branch.

Discussion
----------

[Config] Allow custom meta location in ConfigCache

Fix #19540 and #19496

Commits
-------

91d8296 [Config] Allow custom meta location in ConfigCache
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Config hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
7.1
Development

No branches or pull requests
5 participants
@fabpot @OskarStark @xabbuh @alamirault @carsonbot