-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[Validator] Make PasswordStrengthValidator::estimateStrength()
public
#19903
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
See my comment symfony/symfony#54881 (comment): We should document how we can leverage |
For the documentation, do we update the validator documentation? I've not seen a dedicated PasswordStrength constraint documentation And for the autowiring so we update the generic container documentation or do we add it linked to the constraint/validator doc? |
I was looking on my phone, now that's it's cloned, I found the PasswordStrength doc file. As there is no dedicated documentation for the Validator itself and only for the constraint, I would proposeto add a section "Learn more" at the end of the PasswordStrength constraint doc page that would link to a new page:
The new page would simply indicate :
Would that be a good fit? I'm willing to take a shot at this but it will be my first time updating the documentation, so I might need some guidance (reading the contributing guidelines is ongoing). |
Sounds good to me. Feel free to submit a first draft and we iterate from there. |
…ed documentation (yalit) This PR was squashed before being merged into the 7.2 branch. Discussion ---------- [Validator] feat : add password strength estimator related documentation This PR fixes #19903 Commits ------- 92d1b5a [Validator] feat : add password strength estimator related documentation
Closing as fixed in #19910. |
We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.
To fix this issue, please create a PR against the 7.2 branch in the symfony-docs repository.
Thank you! 😃
The text was updated successfully, but these errors were encountered: