Skip to content

[HttpFoundation] Add $requests parameter to RequestStack constructor #20092

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Aug 3, 2024 · 2 comments
Closed

[HttpFoundation] Add $requests parameter to RequestStack constructor #20092

fabpot opened this issue Aug 3, 2024 · 2 comments
Labels
HttpFoundation
Milestone
7.2

Comments

@fabpot
Copy link
Member

fabpot commented Aug 3, 2024

Q A
Feature PR symfony/symfony#57909
PR author(s) @alexander-schranz
Merged in 7.2

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.2 branch in the symfony-docs repository.

Thank you! 😃
@fabpot fabpot added this to the 7.2 milestone Aug 3, 2024
@OskarStark
Copy link
Contributor

Not sure we need to document this

@xabbuh xabbuh mentioned this issue Aug 20, 2024
Merged
@xabbuh
Copy link
Member

xabbuh commented Aug 20, 2024

see #20135 for one place where we could make use of this

OskarStark added a commit that referenced this issue Aug 20, 2024
@OskarStark
feature #20135 document the requests constructor argument of the Requ…
c909000 
…estStack class (xabbuh)

This PR was merged into the 7.2 branch.

Discussion
----------

document the requests constructor argument of the RequestStack class

fixes #20092

Commits
-------

51fdaa8 document the requests constructor argument of the RequestStack class
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
HttpFoundation
Projects
None yet
Milestone
7.2
Development

No branches or pull requests
4 participants
@fabpot @OskarStark @xabbuh @carsonbot