Skip to content

[Translation] [Loco] Ability to configure value of status query-varia… #20184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Sep 1, 2024 · 2 comments
Closed

[Translation] [Loco] Ability to configure value of status query-varia… #20184

fabpot opened this issue Sep 1, 2024 · 2 comments
Labels
Translation
Milestone
7.2

Comments

@fabpot
Copy link
Member

fabpot commented Sep 1, 2024

Q A
Feature PR symfony/symfony#58072
PR author(s) @mathielen
Merged in 7.2

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.2 branch in the symfony-docs repository.

Thank you! 😃
@fabpot fabpot added this to the 7.2 milestone Sep 1, 2024
@javiereguiluz
Copy link
Member

Note: the docs of these providers are not added directly to the Symfony Docs repository.

The doc about this new feature must be added to the README file of this translation provider: https://github.com/symfony/loco-translation-provider/blob/7.2/README.md (the Pull Request must be submitted against https://github.com/symfony/symfony repository instead of https://github.com/symfony/loco-translation-provider).

See https://github.com/symfony/phrase-translation-provider for an example of a similar provider with its docs in the README.

@MrYamous MrYamous mentioned this issue Sep 6, 2024
Merged
nicolas-grekas added a commit to symfony/symfony that referenced this issue Sep 11, 2024
@nicolas-grekas
minor #58193 [Translation] [Loco] Document status query variable (M…
44395ab 
…rYamous)

This PR was merged into the 7.2 branch.

Discussion
----------

[Translation] [Loco] Document `status` query variable

| Q             | A
| ------------- | ---
| Branch?       | 7.2
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Issues        | [Doc issue](symfony/symfony-docs#20184) - Related to #58072
| License       | MIT

Update readme for Loco bridge documentation

Commits
-------

0a91018 add documentation for Loco query parameter
@javiereguiluz
Copy link
Member

Closing as fixed in symfony/symfony#58193

@xabbuh xabbuh added hasPR A Pull Request has already been submitted for this issue. and removed hasPR A Pull Request has already been submitted for this issue. labels Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Translation
Projects
None yet
Milestone
7.2
Development

No branches or pull requests
4 participants
@fabpot @javiereguiluz @xabbuh @carsonbot