Skip to content

[FrameworkBundle] Remove default value for gc_probability config opti… #20196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Sep 4, 2024 · 2 comments
Closed

[FrameworkBundle] Remove default value for gc_probability config opti… #20196

fabpot opened this issue Sep 4, 2024 · 2 comments
Labels
FrameworkBundle good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Milestone
7.2

Comments

@fabpot
Copy link
Member

fabpot commented Sep 4, 2024

Q A
Feature PR symfony/symfony#58165
PR author(s) @nicolas-grekas
Merged in 7.2

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.2 branch in the symfony-docs repository.

Thank you! 😃
@fabpot fabpot added this to the 7.2 milestone Sep 4, 2024
@javiereguiluz javiereguiluz added the good first issue Ideal for your first contribution! (some Symfony experience may be required) label Sep 4, 2024
@javiereguiluz
Copy link
Member

This is a "good first issue" if anyone wants to start contributing to Symfony Docs.

Check this comment to know what changed in the related PR --> symfony/symfony#58165 (comment)

@raphael-geffroy raphael-geffroy mentioned this issue Sep 6, 2024
Merged
javiereguiluz added a commit that referenced this issue Sep 9, 2024
@javiereguiluz
minor #20204 [FrameworkBundle] Remove default value for `gc_probabili…
65b65a2 
…ty` config option (raphael-geffroy)

This PR was squashed before being merged into the 7.2 branch.

Discussion
----------

[FrameworkBundle] Remove default value for `gc_probability` config option

Fixes #20196

Commits
-------

31a33bf [FrameworkBundle] Remove default value for `gc_probability` config option
@javiereguiluz
Copy link
Member

Closing as fixed in #20204.

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Sep 9, 2024
@MrYamous MrYamous mentioned this issue Dec 2, 2024
Merged
javiereguiluz added a commit that referenced this issue Dec 2, 2024
@javiereguiluz
minor #20428 [Session] Remove a gc_probability default value mentio…
a90dbef 
…n (MrYamous)

This PR was merged into the 7.2 branch.

Discussion
----------

[Session] Remove a `gc_probability` default value mention

Related to #20196

Commits
-------

c71b9f9 remove a gc_probability default mention
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
FrameworkBundle good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
7.2
Development

No branches or pull requests
4 participants
@fabpot @javiereguiluz @xabbuh @carsonbot