Skip to content

Tilde is not rendered in doc #20215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
MrYamous opened this issue Sep 11, 2024 · 4 comments
Closed

Tilde is not rendered in doc #20215

MrYamous opened this issue Sep 11, 2024 · 4 comments
Assignees

Comments

@MrYamous
Copy link
Contributor

MrYamous commented Sep 11, 2024

I noticed in the String documentation a tilde that doesn't appear (the space before 5,000)
Capture d’écran 2024-09-11 à 08 02 18

Do you think it can be a browser issue ? Tried with Chrome and Safari

I remembered this old PR #17624 for a similar issue. If it's about documentation rendering, for this case I think render it as code ~ is not fully appropriate

@javiereguiluz
Copy link
Member

Thanks for reporting this. It looks like a bug, so I created a failing test in the Docs Builder tool that we use in Symfony Docs (see symfony-tools/docs-builder#181).

Hopefully someone can investigate how to fix it. Thanks!

@OskarStark
Copy link
Contributor

We could change it this way:

- of all emojis (~ 5000) ....
+ of all emojis (approx. 5000) ....

and see, if we can fix the parser somehow

javiereguiluz added a commit to symfony-tools/docs-builder that referenced this issue Sep 12, 2024
This PR was merged into the main branch.

Discussion
----------

Add support for tilde characters

Related to
* symfony/symfony-docs#20215

This PR adds a failing test that shows the issue. This is the output change that would make test pass:

```diff
-<p>Excepteur &nbsp;1,000 sint! ...
+<p>Excepteur ~1,000 sint! ...
```

Commits
-------

9223ccc Temporary replace tildes to avoid it being parsed as NBSP
3a300ac Add support for tilde characters
@OskarStark
Copy link
Contributor

@javiereguiluz
Copy link
Member

I'm closing this without merging because the error was solved thanks to the bug fix provided by @wouter in symfony-tools/docs-builder#181

See the tilde character correctly rendered in production: https://symfony.com/doc/current/string.html#working-with-emojis

note: other Symfony Docs versions will be updated when the docs are fully rebuilt tonight.

@javiereguiluz javiereguiluz closed this as not planned Won't fix, can't repro, duplicate, stale Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants