Skip to content

[Mailer][Webhook] Fix SendGrid Webhook parsing #20271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Sep 27, 2024 · 3 comments
Closed

[Mailer][Webhook] Fix SendGrid Webhook parsing #20271

fabpot opened this issue Sep 27, 2024 · 3 comments
Labels
Mailer Webhook
Milestone
7.2

Comments

@fabpot
Copy link
Member

fabpot commented Sep 27, 2024

Q A
Feature PR symfony/symfony#58401
PR author(s) @kbond
Merged in 7.2

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.2 branch in the symfony-docs repository.

Thank you! 😃
@fabpot fabpot added this to the 7.2 milestone Sep 27, 2024
@JohJohan
Copy link
Contributor

JohJohan commented Oct 2, 2024

SendGrid is already documented as having webhook support see: https://symfony.com/doc/current/mailer.html#using-a-3rd-party-transport we now have support for multiple events we could add this as a version added note not sure. @kbond what do you think?

@kbond
Copy link
Member

kbond commented Oct 2, 2024

To me, this is a bug fix that doesn't warrant a versionadded. Admittedly, it is a gray area as the fix requires a new webhook feature. Thoughts from anyone else?

@javiereguiluz
Copy link
Member

I agree too. It looks more like a bug fix, so no need for explicit documentation.

Thanks for checking this!

@javiereguiluz javiereguiluz closed this as not planned Won't fix, can't repro, duplicate, stale Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Mailer Webhook
Projects
None yet
Milestone
7.2
Development

No branches or pull requests
5 participants
@fabpot @javiereguiluz @kbond @JohJohan @carsonbot