Skip to content

[Console] Add finished indicator to ProgressIndicator #20296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fabpot opened this issue Oct 6, 2024 · 1 comment
Closed

[Console] Add finished indicator to ProgressIndicator #20296

fabpot opened this issue Oct 6, 2024 · 1 comment
Labels
Console hasPR A Pull Request has already been submitted for this issue.
Milestone
7.2

Comments

@fabpot
Copy link
Member

fabpot commented Oct 6, 2024

Q A
Feature PR symfony/symfony#57576
PR author(s) @LauLaman
Merged in 7.2

We created this issue to not forget to document this new feature. We would really appreciate if you can help us with this task. If you are not sure how to do it, please ask us and we will help you.

To fix this issue, please create a PR against the 7.2 branch in the symfony-docs repository.

Thank you! 😃
@fabpot fabpot added this to the 7.2 milestone Oct 6, 2024
@Jibbarth Jibbarth mentioned this issue Oct 6, 2024
Merged
javiereguiluz added a commit that referenced this issue Oct 7, 2024
@javiereguiluz
minor #20300 [Console] Document FinishedIndicator for Progress indica…
8fd7a08 
…tor (Jibbarth)

This PR was merged into the 7.2 branch.

Discussion
----------

[Console] Document FinishedIndicator for Progress indicator

Hello 👋

 I give a try to fix #20296

Commits
-------

861a096 [Console] Document FinishedIndicator for Progress indicator
@javiereguiluz
Copy link
Member

Closed by #20300.

@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label Oct 8, 2024
@LauLaman LauLaman mentioned this issue Oct 15, 2024
Merged
javiereguiluz added a commit that referenced this issue Oct 16, 2024
@javiereguiluz
minor #20331 [Console] Update FinishedIndicator documentation for Pro…
f02c2ab 
…gress indicator (LauLaman)

This PR was merged into the 7.2 branch.

Discussion
----------

[Console] Update FinishedIndicator documentation for Progress indicator

Hi!

This is a correction to PR #20300 Which makes a wrong statement about the finished indicator.

This MR seeks to resolve this and make the documentation more clear

closes #20296

Commits
-------

93ca378 Update progressindicator.rst
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Console hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
7.2
Development

No branches or pull requests
4 participants
@fabpot @javiereguiluz @xabbuh @carsonbot