-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
:method: role creates wrong url #2156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@wouterj - nice detective work :). Yes, I completely agree - looks like symfony.com is perhaps using an older version of the sphinx extensions which are causing these |
@weaverryan strangly enough, the |
ping again @fabpot I think it is important to fix this, as broken links in the documentation is not something people like... |
ping @fabpot, this is an urgent bug as nobody likes not working links |
ping @fabpot @sensiolabs @...? Could anybody please take a look at the website issues for a day and fix some of them? Some important issues: |
ping @javiereguiluz this is a very important bug which is open for too long if you ask me :) |
@javiereguiluz can you update the submodule on the doc builder ? The symfony-docs repo points to a fixed version of the extension since months, but it looks like the prod has not updated the submodules since a very long time. |
ping @javiereguiluz |
problem still existing, the submodule points to the fixed version of sphinx-php. Just need a |
what needs to run on the build server is |
The whole process of generating the documentation will be revisited if I'm correct, so I hope this can be fixed then too. |
@fabpot links to API methods look wrong (they are The solution could be easy because according to @stof the server is using an outdated version of |
@javiereguiluz to be clear, the submodule in the symfony-docs repo points to a working version since several months. But it looks like |
Given that the extension was updated recently, the issue must be something else. |
@javiereguiluz could it be possible that |
@stof |
This is happening again |
It's still happening :) However, the extension existed before the repository existed and this was one of its earlier extensions. Could it be possible that the documentation build process is using the 2 extensions, both the old one and the repository that already exists? Or maybe this was registered somewhere else and when the extensions were open sourced, they forgot to point to the correct file? @javiereguiluz to check this easily by checking the |
Is there really nothing we can do about this? |
@wouterj @weaverryan As a last resort, we could use the |
I will take care of this issue and I'll try to provide a definitive answer soon. |
@javiereguiluz Thank you very much. |
@javiereguiluz do you have an answer already? |
@wouterj unfortunately I don't. I have sent several emails about this to the person responsible of fixing it but I never got a response :( |
@fabpot @javiereguiluz I don't want to sound harsh, but it really is a pity to have this issue open for so long. Is there anything that we can do to solve this? |
@xabbuh this issue may have been finally solved. A change has been deployed and it will be applied the next time the documentation is rebuilt. Let's wait and see. |
Woot, great news :) (and just in time, I was planning to ping you on this at the meeting this afternoon 😉 ) |
You may not believe me, but I really did not read your comments before the meeting. :) |
I'm happy to confirm that this error has been fixed and now all the |
woohoo 👍 |
We have a very strange error on the documentation. If you take a look at http://symfony.com/doc/current/components/finder.html (or any other article which uses the
:method:
role) the links to the API docs for methods become something like this:http://api.symfony.com/2.1/Symfony/Component/Finder/Finder.html#exclude()
while it should become this:http://api.symfony.com/2.1/Symfony/Component/Finder/Finder.html#method_exclude
.I thought it was an error in the extensions created by Fabian, but that looked correct:
The link that is created looks like the old way of generating links. When we changed to the new link format in the API doc generator, @weaverryan had changed this 8 months ago in: fabpot/sphinx-php@a9d5ec5
To me, it looks like the documentation generator uses an old version of the sphinx extensions by Fabien.
/cc @fabpot
@weaverryan this should get a 'website' label
The text was updated successfully, but these errors were encountered: