Skip to content

Update PHP examples to reflect changes as of 2.2 #2719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wouterj opened this issue Jun 12, 2013 · 0 comments
Closed

Update PHP examples to reflect changes as of 2.2 #2719

wouterj opened this issue Jun 12, 2013 · 0 comments
Labels
actionable Clear and specific issues ready for anyone to take them. bug good first issue Ideal for your first contribution! (some Symfony experience may be required)
Milestone
2.2

Comments

@wouterj
Copy link
Member

wouterj commented Jun 12, 2013

The Routing component had a lot of deprecations in 2.2. The PHP examples of the configuration blocks aren't updated to follow these changes.

Example:

.. configuration-block::

    .. ...

    .. code-block:: php

        // ...
        $collection->addCollection($loader->import("..."), '/admin');

Should become:

.. configuration-block::

    .. ...

    .. code-block:: php

        // ...
        $acmeHello = $loader->import("...");
        $acmeHello->setPrefix('/admin');
        $collection->addCollection($acmeHello);

Please note that the first change, the change of the routing option names, is already fixed in the documetation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. bug good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Milestone
2.2
Development

No branches or pull requests
1 participant
@wouterj