@gondo I know that you've fixed many of these issues in #2765, but I'm not sure which issues have been fixed and which have not. I've changed your original questions into checkmark boxes. Can you "check off" the items that have already been fixed? Then we can work through any remaining items.

Thanks!

hi, pretty much everything was addressed in my pull request. however:
3. - password generation - was not explained as it is not needed. i've provided working example and the new user can be generated by registration or extra code what is linked in the tutorial. the question is, if this is obvious at the point when the new user is reading this? i can understand how things work now, but i had to read much more to get to this point.
7. - Group vs Role - i've noticed that later in documentation you use Groups rather than Roles. i understand that this is more of a choice than convention, i think its wrong as i prefer role to be called Role (not Group). i've changed Group to Role in my pull request but this might break compatibility with later tutorial.
this is not necessary wrong, as Role/s are core classes in symfony, but it just inconsistance with the rest of the tutorials.

@gondo

About 3, I do think that we should at least link to other places in the documentation that show you how you would actually create users. It does seem a little incomplete that you can set all of this up, but that without any data (users, roles) in the database, you can't really do anything.

About 7, which later tutorial are you talking about that mentions Group? I don't see anything else (but let me know), so I don't think this is an issue. I actually like your change from Group to Role. We do sometimes use "Group" in the Symfony world, but usually in those cases, a "Group" represents many roles, not just one role. You can see this idea, for example, in the FOSUserBundle. So, I liked your change to Role.

1. agree, unfortunately i do not have time to get back to this
2. you are absolutely right, the concept of groups seems to be used just in FOSUserBundle

So the only thing to fix now is (3).

@gondo thanks for your great work improving this tutorial!

I have another suggestion. Some user asked on IRC what is or where is the User bundle that mentions the tutorial. Specifically, this is the phrase that should be improved:

This tutorial assumes there is a bootstrapped and loaded Acme\UserBundle bundle in the application kernel.

Something like this would be enough (obviously with a proper English wording):

For the sake of simplificty, this article assumes that you already have a bundle called UserBundle under the Acme namespace. Your application bundle name and location could of course vary.

And there's another problem. It assumes you have a User entity. If you don't have that yet, it doesn't help you know how to create this. It does below say you can generate your getters/setters using php app/console doctrine:generate:entities Acme/UserBundle/Entity/User, which a user in IRC tried (thinking it would generate the User entity).

I think we need to actually guide people (not necessarily here, but point to other links) on how to create their bundle and generate the entity if they don't have one.

This issue seems to have been solved in the merged #2765 PR. If that's true, should we close it?

I'll close this - I've almost certainly checked off the last item with #5083

Thanks!