Skip to content

[2.1] Document immutable event dispatcher #2858

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wouterj opened this issue Jul 27, 2013 · 5 comments
Closed

[2.1] Document immutable event dispatcher #2858

wouterj opened this issue Jul 27, 2013 · 5 comments
Labels
actionable Clear and specific issues ready for anyone to take them. EventDispatcher good first issue Ideal for your first contribution! (some Symfony experience may be required)
Milestone
2.1

Comments

@wouterj
Copy link
Member

wouterj commented Jul 27, 2013

The ImmutableEventDispatcher cannot be modified. It takes another dispatcher with the listeners and subscribers.

Ideally, it'll be placed in the same document as the Container aware dipatcher.
@xabbuh
Copy link
Member

xabbuh commented Jul 27, 2013

What's the reason to put this into 2.1?

@wouterj
Copy link
Member Author

wouterj commented Jul 27, 2013

It's added in 2.1

@xabbuh
Copy link
Member

xabbuh commented Jul 27, 2013

Does this mean we add it also to the 2.1 branch or is this milestone more kind of informal?

@wouterj
Copy link
Member Author

wouterj commented Jul 27, 2013

That's something ryan and I cannot agree on with eachother...

Imo, it should be documented in the 2.1 branch.

@weaverryan
Copy link
Member

I'm fine with 2.1. Obviously 2.1 is beyond its end of life, but since this is new in 2.1, and since it would represent a new document or at least a new standalone section, the risk to big conflict is low. I think 2.1 should usually be treated as deprecated, but I don't see much harm in bending those rules if we want to push a few things into it. But it should be rare - deprecated branches fall out of sync over time.

Thanks!

@wouterj wouterj mentioned this issue Jul 30, 2013
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. EventDispatcher good first issue Ideal for your first contribution! (some Symfony experience may be required)
Projects
None yet
Milestone
2.1
Development

No branches or pull requests
3 participants
@weaverryan @wouterj @xabbuh