Skip to content

missing image in contributing guide #3192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HassanCehef opened this issue Nov 17, 2013 · 5 comments
Closed

missing image in contributing guide #3192

HassanCehef opened this issue Nov 17, 2013 · 5 comments
Labels

Comments

@HassanCehef
Copy link

Hi,
Tonight, I downloaded the contributing guide 2.3 on the Symfony site. Page 40 out 46, there is a missing image, we can see the path instead.
I did not check other languages (not even the French version)

contributingsymfonymissingimage

I hope it helped.

@xabbuh
Copy link
Member

xabbuh commented Nov 17, 2013

This seems to be a general problem (see for example page 181 in the Components docs). Seems like _images is used to search for images instead of images.

ping @fabpot

@wouterj
Copy link
Member

wouterj commented Nov 17, 2013

with the CMF docs, we also have this problem. But there, we use the _images directory (which I also prefer over images). Seems the hole path is incorrect, not only the directory name

@xabbuh
Copy link
Member

xabbuh commented Nov 17, 2013

see also #1981

@xabbuh
Copy link
Member

xabbuh commented Jul 26, 2014

@javiereguiluz Do you have an idea what's going wrong?

weaverryan added a commit that referenced this issue Sep 15, 2014
…reguiluz)

This PR was merged into the 2.3 branch.

Discussion
----------

Moved 'contributing' images to their own directory

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | #3192

The PDF version of the "Contributing Guide" doesn't show the images (as reported in #3192). The rest of the PDFs correctly show them. Although I don't know the exact cause of the error, the "Contributing" guide images weren't stored in their own subdirectory inside `images/` and named after the book. That's the only difference between the right and the wrong PDF files.

For compatibility reasons I've left on purpose the original images at their location and just made a copy in the new directory.

Commits
-------

fc15b65 Moved 'contributing' images to their own directory
@fabpot
Copy link
Member

fabpot commented Dec 3, 2014

Images in PDF files are now correctly imported.

@fabpot fabpot closed this as completed Dec 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants